[Backport 2.x] [Auto Suggest] PPL autocomplete and interface changes #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Autocomplete - SQL] Minor interface change to add suggestion type and move suggestion provider registration location (#7758) * add table/source as prefix to suggested fields Signed-off-by: Eric <menwe@amazon.com> * add type to column Signed-off-by: Eric <menwe@amazon.com> * move registeration to osd/monaco Signed-off-by: Eric <menwe@amazon.com> * add detail Signed-off-by: Eric <menwe@amazon.com> * Changeset file for PR #7758 created/updated --------- Signed-off-by: Eric <menwe@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [Autocomplete] PPL Autocomplete (#7810) * add initial ppl autocomplete Signed-off-by: Eric <menwe@amazon.com> * untrack .antlr files Signed-off-by: Eric <menwe@amazon.com> * ignore intermediate grammar auto-gen files Signed-off-by: Eric <menwe@amazon.com> * add rules and related functionalities Signed-off-by: Eric <menwe@amazon.com> * Changeset file for PR #7810 created/updated * Changeset file for PR #7810 created/updated * minor comment cleanning Signed-off-by: Eric <menwe@amazon.com> * add ppl generation command Signed-off-by: Eric <menwe@amazon.com> * add rules Signed-off-by: Eric <menwe@amazon.com> * correct typo Signed-off-by: Eric <menwe@amazon.com> * fix inserting text issue Signed-off-by: Eric <menwe@amazon.com> * remove colon for PPL field Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * small interface updates Signed-off-by: Paul Sebastian <paulstn@amazon.com> * small type update Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make inclusion for pipe, comma, and equal tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor and generalize field fetcher for dql and ppl, including details Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use field fetching util for sql and update sugg detail for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * detail for ppl Signed-off-by: Paul Sebastian <paulstn@amazon.com> * create range parameter to help identify suggestions with whitespace, implemented dql value WS suggs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * single line editor overflow initial override for sugg window Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update dql tests to account for details and value ranges Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 0245540) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
discover
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
ashwin-pc
approved these changes
Aug 30, 2024
joshuali925
approved these changes
Aug 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7950 +/- ##
==========================================
- Coverage 64.38% 61.02% -3.37%
==========================================
Files 3663 3670 +7
Lines 80917 86755 +5838
Branches 12902 13334 +432
==========================================
+ Hits 52102 52938 +836
- Misses 25620 30620 +5000
- Partials 3195 3197 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 0245540 from #7932.