Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Hide saved object import button when user is outside workspace #7989

Merged

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Sep 4, 2024

Description

Hide saved object import button in the save object management page(assets page)when user is outside workspace.

Issues Resolved

Related issue #4944

Screenshot

outside workspace
image
inside a workspace
image

Testing the changes

Changelog

  • refactor: Hide saved object import button when user is outside workspace

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.09%. Comparing base (7dedc58) to head (ab6f942).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...gement_section/objects_table/components/header.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7989   +/-   ##
=======================================
  Coverage   61.09%   61.09%           
=======================================
  Files        3691     3691           
  Lines       87310    87313    +3     
  Branches    13433    13436    +3     
=======================================
+ Hits        53340    53343    +3     
  Misses      30722    30722           
  Partials     3248     3248           
Flag Coverage Δ
Linux_1 29.32% <0.00%> (-0.01%) ⬇️
Linux_2 56.24% <ø> (ø)
Linux_3 37.93% <0.00%> (-0.01%) ⬇️
Linux_4 29.59% <66.66%> (+<0.01%) ⬆️
Windows_1 29.34% <0.00%> (-0.01%) ⬇️
Windows_2 56.19% <ø> (ø)
Windows_3 37.93% <0.00%> (-0.01%) ⬇️
Windows_4 29.59% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl merged commit 35be041 into opensearch-project:main Sep 5, 2024
74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
…pace (#7989)

* Hide saved object import button when user is outside workpace

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7989 created/updated

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 35be041)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 5, 2024
…pace (#7989) (#8014)

* Hide saved object import button when user is outside workpace



* Changeset file for PR #7989 created/updated

---------



(cherry picked from commit 35be041)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
…pace (#7989) (#8014)

* Hide saved object import button when user is outside workpace

* Changeset file for PR #7989 created/updated

---------

(cherry picked from commit 35be041)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit 81ccf48)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
…pace (#7989) (#8014) (#8041)

* Hide saved object import button when user is outside workpace

* Changeset file for PR #7989 created/updated

---------

(cherry picked from commit 35be041)






(cherry picked from commit 81ccf48)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants