[navigation] Add workspace icon to left nav / workspace picker menu / home page. (#7823) #7994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… home page. (opensearch-project#7823) * feat: show workspace picker content in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: only register index patterns to settings and setup when workspace is disabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: put discover 2.0 behind discover Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: improve test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge conflict Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize filter code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new icon to left navigation and workspace picker menu Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change use case card in home Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize alignment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7823 created/updated * feat: alignment optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use new icons in workspace picker Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize color Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add workspace icon in workspace creator (#19) Signed-off-by: Lin Wang <wonglam@amazon.com> * fix: fatal error when visibleUseCases is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 1974ca1)
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
SuZhou-Joe
merged commit cbdb0fd
into
opensearch-project:feature/navigation-next-2.x
3 of 4 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
… home page. (#7823) (#7994) * feat: show workspace picker content in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: only register index patterns to settings and setup when workspace is disabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: put discover 2.0 behind discover Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: improve test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge conflict Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize filter code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new icon to left navigation and workspace picker menu Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change use case card in home Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize alignment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7823 created/updated * feat: alignment optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use new icons in workspace picker Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize color Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add workspace icon in workspace creator (#19) Signed-off-by: Lin Wang <wonglam@amazon.com> * fix: fatal error when visibleUseCases is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 5, 2024
… home page. (#7823) (#7994) (#7995) * feat: show workspace picker content in left nav * fix: bootstrap error * fix: unit test error * feat: finish picker content * feat: finish picker content * feat: only register index patterns to settings and setup when workspace is disabled * fix: unit test * feat: put discover 2.0 behind discover * feat: add coverage * feat: improve test coverage * feat: merge conflict * feat: optimize code based on comment * feat: optimize code based on comment * feat: optimize filter code * feat: update * feat: add new icon to left navigation and workspace picker menu * feat: change use case card in home * feat: optimize alignment * Changeset file for PR #7823 created/updated * feat: alignment optimize * feat: use new icons in workspace picker * feat: optimize color * fix: unit test error * fix: unit test * fix: unit test * feat: increase test coverage * feat: remove useless code * Add workspace icon in workspace creator (#19) * fix: fatal error when visibleUseCases is empty --------- (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
… home page. (#7823) (#7994) (#7995) * feat: show workspace picker content in left nav * fix: bootstrap error * fix: unit test error * feat: finish picker content * feat: finish picker content * feat: only register index patterns to settings and setup when workspace is disabled * fix: unit test * feat: put discover 2.0 behind discover * feat: add coverage * feat: improve test coverage * feat: merge conflict * feat: optimize code based on comment * feat: optimize code based on comment * feat: optimize filter code * feat: update * feat: add new icon to left navigation and workspace picker menu * feat: change use case card in home * feat: optimize alignment * Changeset file for PR #7823 created/updated * feat: alignment optimize * feat: use new icons in workspace picker * feat: optimize color * fix: unit test error * fix: unit test * fix: unit test * feat: increase test coverage * feat: remove useless code * Add workspace icon in workspace creator (#19) * fix: fatal error when visibleUseCases is empty --------- (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 4c64d81) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 6, 2024
… home page. (#7823) (#7994) (#7995) (#8038) * feat: show workspace picker content in left nav * fix: bootstrap error * fix: unit test error * feat: finish picker content * feat: finish picker content * feat: only register index patterns to settings and setup when workspace is disabled * fix: unit test * feat: put discover 2.0 behind discover * feat: add coverage * feat: improve test coverage * feat: merge conflict * feat: optimize code based on comment * feat: optimize code based on comment * feat: optimize filter code * feat: update * feat: add new icon to left navigation and workspace picker menu * feat: change use case card in home * feat: optimize alignment * Changeset file for PR #7823 created/updated * feat: alignment optimize * feat: use new icons in workspace picker * feat: optimize color * fix: unit test error * fix: unit test * fix: unit test * feat: increase test coverage * feat: remove useless code * Add workspace icon in workspace creator (#19) * fix: fatal error when visibleUseCases is empty --------- (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) (cherry picked from commit 4c64d81) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration