Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x] Bump browserslist to prevent integration test errors (#8102) #8144

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[Manual backport 2.x] Bump browserslist to prevent integration test errors (#8102) #8144

merged 1 commit into from
Sep 18, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Cherry-picked 22f1d46 from #8102

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki AMoo-Miki mentioned this pull request Sep 11, 2024
Merged
7 tasks
@AMoo-Miki AMoo-Miki changed the title Bump browserslist to prevent integration test errors (#8102) [Manual backport 2.x] Bump browserslist to prevent integration test errors (#8102) Sep 11, 2024
@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 11, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.92%. Comparing base (aa74401) to head (79278bc).
Report is 20 commits behind head on 2.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##              2.x    #8144   +/-   ##
=======================================
  Coverage   63.92%   63.92%           
=======================================
  Files        3737     3737           
  Lines       88717    88726    +9     
  Branches    13792    13795    +3     
=======================================
+ Hits        56714    56721    +7     
  Misses      31407    31407           
- Partials      596      598    +2
Flag Coverage Δ
Linux_1 29.96% <ø> (+<0.01%) ⬆️
Linux_2 58.91% <ø> (ø)
Linux_3 40.29% <ø> (ø)
Linux_4 31.33% <ø> (ø)
Windows_1 29.98% <ø> (+<0.01%) ⬆️
Windows_2 58.86% <ø> (ø)
Windows_3 40.29% <ø> (-0.01%) ⬇️
Windows_4 31.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joshuali925
joshuali925 previously approved these changes Sep 11, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@AMoo-Miki AMoo-Miki merged commit 2246db5 into opensearch-project:2.x Sep 18, 2024
65 of 66 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
@github-actions
Bump browserslist to prevent integration test errors (#8102) (#8144)
d22f426 
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 2246db5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 18, 2024
Merged
abbyhu2000 pushed a commit that referenced this pull request Sep 21, 2024
@opensearch-trigger-bot @github-actions
Bump browserslist to prevent integration test errors (#8102) (#8144) (#…
fdf733b 
…8234)

(cherry picked from commit 2246db5)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@abbyhu2000
Revert "Bump browserslist to prevent integration test errors (opensea…
42c15f5 
…rch-project#8102) (opensearch-project#8144) (opensearch-project#8234)"

This reverts commit fdf733b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@virajsanghvi virajsanghvi virajsanghvi approved these changes

@joshuali925 joshuali925 joshuali925 left review comments

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.17 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AMoo-Miki @virajsanghvi @kavilla @joshuali925 @ashwin-pc