-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactored src/core/server/audit_trai,capabilties,config,cor… #86
Merged
boktorbb
merged 4 commits into
opensearch-project:dashboards
from
mihirsoni:src/core/server/dirs
Mar 12, 2021
Merged
[Rename] Refactored src/core/server/audit_trai,capabilties,config,cor… #86
boktorbb
merged 4 commits into
opensearch-project:dashboards
from
mihirsoni:src/core/server/dirs
Mar 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_app Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
suggested changes
Mar 12, 2021
src/core/server/core_app/integration_tests/default_route_provider_config.test.ts
Outdated
Show resolved
Hide resolved
src/core/server/core_app/integration_tests/default_route_provider_config.test.ts
Outdated
Show resolved
Hide resolved
src/core/server/core_app/integration_tests/default_route_provider_config.test.ts
Outdated
Show resolved
Hide resolved
src/core/server/core_app/integration_tests/default_route_provider_config.test.ts
Outdated
Show resolved
Hide resolved
src/core/server/core_app/integration_tests/default_route_provider_config.test.ts
Outdated
Show resolved
Hide resolved
ananzh
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All goods besides Bishoy's comments.
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
…… (#86) * [Rename] Refactored src/core/server/audit_trai,capabilties,config,core_app Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/core_usage_data,csp,environment Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] renamed missing keywords Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] addressed PR comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
#86) * [Rename] Refactored src/core/server/audit_trai,capabilties,config,core_app Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/core_usage_data,csp,environment Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] renamed missing keywords Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] addressed PR comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
#86) * [Rename] Refactored src/core/server/audit_trai,capabilties,config,core_app Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/core_usage_data,csp,environment Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] renamed missing keywords Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] addressed PR comments Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Aug 17, 2023
* place current workspace at the top of worksapce list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * prototype for workspace context menu and picker menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve import issue and add props to test Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move formatUrlWithWorkspaceId from plugin workspace to core Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add workspaceEnabled props Signed-off-by: yuye-aws <yuyezhu@amazon.com> * implement logo and color for context and picker menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bold texts Signed-off-by: yuye-aws <yuyezhu@amazon.com> * workspace disabled left menu header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move workspace applications to picker menu and context menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor workspace disabled logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add app id constants Signed-off-by: yuye-aws <yuyezhu@amazon.com> * only highlight current workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix type error and key error Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix icon bug and import management workspace const Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change const order Signed-off-by: yuye-aws <yuyezhu@amazon.com> * warp string with i18n Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor getFilteredWorkspaceList function Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused props Signed-off-by: yuye-aws <yuyezhu@amazon.com> * avoid inline styles Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
* place current workspace at the top of worksapce list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * prototype for workspace context menu and picker menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve import issue and add props to test Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move formatUrlWithWorkspaceId from plugin workspace to core Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add workspaceEnabled props Signed-off-by: yuye-aws <yuyezhu@amazon.com> * implement logo and color for context and picker menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bold texts Signed-off-by: yuye-aws <yuyezhu@amazon.com> * workspace disabled left menu header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move workspace applications to picker menu and context menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor workspace disabled logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add app id constants Signed-off-by: yuye-aws <yuyezhu@amazon.com> * only highlight current workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix type error and key error Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix icon bug and import management workspace const Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change const order Signed-off-by: yuye-aws <yuyezhu@amazon.com> * warp string with i18n Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor getFilteredWorkspaceList function Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused props Signed-off-by: yuye-aws <yuyezhu@amazon.com> * avoid inline styles Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
* place current workspace at the top of worksapce list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * prototype for workspace context menu and picker menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve import issue and add props to test Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move formatUrlWithWorkspaceId from plugin workspace to core Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add workspaceEnabled props Signed-off-by: yuye-aws <yuyezhu@amazon.com> * implement logo and color for context and picker menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bold texts Signed-off-by: yuye-aws <yuyezhu@amazon.com> * workspace disabled left menu header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move workspace applications to picker menu and context menu Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor workspace disabled logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add app id constants Signed-off-by: yuye-aws <yuyezhu@amazon.com> * only highlight current workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix type error and key error Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix icon bug and import management workspace const Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change const order Signed-off-by: yuye-aws <yuyezhu@amazon.com> * warp string with i18n Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor getFilteredWorkspaceList function Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused props Signed-off-by: yuye-aws <yuyezhu@amazon.com> * avoid inline styles Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Issue #, if available:
Description of changes:
Changes the following directories
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.