-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactored src/core/server/utils,ui_settings,status,root directory #92
[Rename] Refactored src/core/server/utils,ui_settings,status,root directory #92
Conversation
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/core/server/index.ts
Outdated
kibanaResponseFactory, | ||
KibanaResponseFactory, | ||
OpenSearchDashboardsResponseFactory, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only OpenSearchDashboardsResponseFactory added and not opensearchDashboardsResponseFactory as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ectory (#92) * [Rename] Refactored src/core/server/status directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/ui_settings directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/utils directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/ directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] renamed missing keywords Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
…ectory (#92) * [Rename] Refactored src/core/server/status directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/ui_settings directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/utils directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/ directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] renamed missing keywords Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
…ectory (#92) * [Rename] Refactored src/core/server/status directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/ui_settings directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/utils directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] Refactored src/core/server/ directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] renamed missing keywords Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
…-project#92) Signed-off-by: Lin Wang <wonglam@amazon.com>
…-project#92) Signed-off-by: Lin Wang <wonglam@amazon.com>
…-project#92) Signed-off-by: Lin Wang <wonglam@amazon.com>
Issue #, if available: #37
Description of changes: Refactored src/core/server/utils,ui_settings,status,root directory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.