-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactored src/plugins/vis_type_timelion directory #99
Merged
mihirsoni
merged 2 commits into
opensearch-project:dashboards
from
mihirsoni:src/plugins/vis_type_timelion
Mar 12, 2021
Merged
[Rename] Refactored src/plugins/vis_type_timelion directory #99
mihirsoni
merged 2 commits into
opensearch-project:dashboards
from
mihirsoni:src/plugins/vis_type_timelion
Mar 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ananzh
reviewed
Mar 11, 2021
src/plugins/vis_type_timelion/public/components/timelion_expression_input_helpers.test.ts
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
src/plugins/vis_type_timelion/public/components/timelion_interval.tsx
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
src/plugins/vis_type_timelion/public/helpers/plugin_services.ts
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
src/plugins/vis_type_timelion/public/helpers/timelion_request_handler.ts
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
src/plugins/vis_type_timelion/public/helpers/xaxis_formatter.ts
Outdated
Show resolved
Hide resolved
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
reviewed
Mar 11, 2021
ananzh
requested changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few missing "/", like 'opensearch-dashboardsserver'
A few missing Es, like getEsQueryConfig--->getOpenSearchQueryConfig
Others all good.
ananzh
approved these changes
Mar 12, 2021
kavilla
referenced
this pull request
in kavilla/OpenSearch-Dashboards
Mar 19, 2021
* [Rename] Refactored src/plugins/vis_type_timelion directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] addressed review feedbacks
kavilla
pushed a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_timelion directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] addressed review feedbacks
mihirsoni
added a commit
that referenced
this pull request
Mar 20, 2021
* [Rename] Refactored src/plugins/vis_type_timelion directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com> * [Rename] addressed review feedbacks
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Aug 24, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Issue #, if available: #37
Description of changes: Refactored src/plugins/vis_type_timelion directory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.