revert AbstractAsyncTask changes

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
opensearch-project · Jun 5, 2024 · 17298fc · 17298fc
1 parent f0f6188
commit 17298fc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 18 deletions.
diff --git a/...nalClusterTest/java/org/opensearch/gateway/remote/RemoteClusterStateCleanupManagerIT.java b/...nalClusterTest/java/org/opensearch/gateway/remote/RemoteClusterStateCleanupManagerIT.java
@@ -129,6 +129,15 @@ public void testRemoteCleanupDeleteStale() throws Exception {
                 manifestFiles >= RETAINED_MANIFESTS && manifestFiles < RETAINED_MANIFESTS + 2 * SKIP_CLEANUP_STATE_CHANGES
             );
         }, 500, TimeUnit.MILLISECONDS);
+
+        // disable the clean up to avoid race condition during shutdown
+        response = client().admin()
+            .cluster()
+            .prepareUpdateSettings()
+            .setPersistentSettings(Settings.builder().put(REMOTE_CLUSTER_STATE_CLEANUP_INTERVAL_SETTING.getKey(), "-1"))
+            .get();
+
+        assertTrue(response.isAcknowledged());
     }
 
     private void updateClusterStateNTimes(int n) {

diff --git a/server/src/main/java/org/opensearch/common/util/concurrent/AbstractAsyncTask.java b/server/src/main/java/org/opensearch/common/util/concurrent/AbstractAsyncTask.java
@@ -34,7 +34,6 @@
 import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.message.ParameterizedMessage;
 import org.opensearch.common.unit.TimeValue;
-import org.opensearch.core.concurrency.OpenSearchRejectedExecutionException;
 import org.opensearch.threadpool.Scheduler;
 import org.opensearch.threadpool.ThreadPool;
 
@@ -107,23 +106,7 @@ public synchronized void rescheduleIfNecessary() {
             if (logger.isTraceEnabled()) {
                 logger.trace("scheduling {} every {}", toString(), interval);
             }
-            try {
-                cancellable = threadPool.schedule(this, interval, getThreadPool());
-            } catch (OpenSearchRejectedExecutionException e) {
-                if (e.isExecutorShutdown()) {
-                    logger.debug(
-                        new ParameterizedMessage(
-                            "could not schedule execution of [{}] after [{}] on [{}] as executor is shut down",
-                            this,
-                            interval,
-                            getThreadPool()
-                        ),
-                        e
-                    );
-                } else {
-                    throw e;
-                }
-            }
+            cancellable = threadPool.schedule(this, interval, getThreadPool());
             isScheduledOrRunning = true;
         } else {
             logger.trace("scheduled {} disabled", toString());