Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
opensearch-project · Mar 4, 2022 · 17c0abb · 17c0abb
1 parent 45665db
commit 17c0abb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/server/src/main/java/org/opensearch/index/engine/EngineConfigFactory.java b/server/src/main/java/org/opensearch/index/engine/EngineConfigFactory.java
@@ -98,9 +98,9 @@ public EngineConfigFactory(PluginsService pluginsService, IndexSettings idxSetti
             }
             // get overriding CodecServiceFactory from EnginePlugin
             if (codecServiceFactory.isPresent() == false) {
-                codecServiceFactory = enginePlugin.getCustomCodecServiceFactory();
+                codecServiceFactory = enginePlugin.getCustomCodecServiceFactory(idxSettings);
                 codecServiceFactoryOverridingPlugin = enginePlugin.getClass().getName();
-            } else if (enginePlugin.getCustomCodecServiceFactory().isPresent()) {
+            } else if (enginePlugin.getCustomCodecServiceFactory(idxSettings).isPresent()) {
                 throw new IllegalStateException(
                     "existing codec service factory already overridden in: "
                         + codecServiceFactoryOverridingPlugin

diff --git a/server/src/main/java/org/opensearch/plugins/EnginePlugin.java b/server/src/main/java/org/opensearch/plugins/EnginePlugin.java
@@ -80,7 +80,7 @@ default Optional<CodecService> getCustomCodecService(IndexSettings indexSettings
      * the {@link CodecServiceFactory} through the plugin can ignore this method and the default Codec specified in the
      * {@link IndexSettings} will be used.
      */
-    default Optional<CodecServiceFactory> getCustomCodecServiceFactory() {
+    default Optional<CodecServiceFactory> getCustomCodecServiceFactory(IndexSettings indexSettings) {
         return Optional.empty();
     }
 

diff --git a/server/src/test/java/org/opensearch/index/engine/EngineConfigFactoryTests.java b/server/src/test/java/org/opensearch/index/engine/EngineConfigFactoryTests.java
@@ -182,7 +182,7 @@ public Optional<EngineFactory> getEngineFactory(final IndexSettings indexSetting
         }
 
         @Override
-        public Optional<CodecServiceFactory> getCustomCodecServiceFactory() {
+        public Optional<CodecServiceFactory> getCustomCodecServiceFactory(IndexSettings indexSettings) {
             return Optional.of(config -> new CodecService(config.getMapperService(), LogManager.getLogger(getClass())));
         }
     }