Formatting sizeOfSegmentFiles for time calculation.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
opensearch-project · Sep 6, 2022 · 3fb0e25 · 3fb0e25
1 parent 8138702
commit 3fb0e25
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -47,7 +47,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Fix NoSuchFileExceptions with segment replication when computing primary metadata snapshots ([#4366](https://github.com/opensearch-project/OpenSearch/pull/4366))
 - [Segment Replication] Update flaky testOnNewCheckpointFromNewPrimaryCancelOngoingReplication unit test ([#4414](https://github.com/opensearch-project/OpenSearch/pull/4414))
 - Fixed the `_cat/shards/10_basic.yml` test cases fix.
-- Fix timeout issue by calculating time needed to process getSegmentFiles
+- [Segment Replication] Fix timeout issue by calculating time needed to process getSegmentFiles ([#4426](https://github.com/opensearch-project/OpenSearch/pull/4426))
 
 ### Security
 - CVE-2022-25857 org.yaml:snakeyaml DOS vulnerability ([#4341](https://github.com/opensearch-project/OpenSearch/pull/4341))

diff --git a/server/src/main/java/org/opensearch/indices/replication/PrimaryShardReplicationSource.java b/server/src/main/java/org/opensearch/indices/replication/PrimaryShardReplicationSource.java
@@ -89,7 +89,9 @@ public void getSegmentFiles(
             sizeOfSegmentFiles += filesToFetch.get(i).length();
         }
         // Making sure files size is in correct format to perform time calculation.
-        sizeOfSegmentFiles = Math.abs(sizeOfSegmentFiles);
+        if(sizeOfSegmentFiles<0){
+            sizeOfSegmentFiles *=-1;
+        }
         // Maximum size of files to fetch (segment files), that can be processed in 1 minute for a m5.xlarge machine.
         long baseSegmentFilesSize = 300000000;