Addressing code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
opensearch-project · Oct 19, 2022 · 9621cc5 · 9621cc5
1 parent a9ed595
commit 9621cc5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -142,7 +142,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Fix decommission status update to non leader nodes ([4800](https://github.com/opensearch-project/OpenSearch/pull/4800))
 - Fix recovery path for searchable snapshots ([4813](https://github.com/opensearch-project/OpenSearch/pull/4813))
 - Fix bug in AwarenessAttributeDecommissionIT([4822](https://github.com/opensearch-project/OpenSearch/pull/4822))
-- Addressing 'org.apache.hc.core5.http.ParseException: Invalid protocol version' under JDK 16+ ([#4827](https://github.com/opensearch-project/OpenSearch/pull/4827))
+- Fix 'org.apache.hc.core5.http.ParseException: Invalid protocol version' under JDK 16+ ([#4827](https://github.com/opensearch-project/OpenSearch/pull/4827))
 
 ### Security
 - CVE-2022-25857 org.yaml:snakeyaml DOS vulnerability ([#4341](https://github.com/opensearch-project/OpenSearch/pull/4341))

diff --git a/client/rest/src/main/java/org/opensearch/client/RestClientBuilder.java b/client/rest/src/main/java/org/opensearch/client/RestClientBuilder.java
@@ -316,7 +316,7 @@ private CloseableHttpAsyncClient createHttpClient() {
         try {
             final TlsStrategy tlsStrategy = ClientTlsStrategyBuilder.create()
                 .setSslContext(SSLContext.getDefault())
-                // See please https://issues.apache.org/jira/browse/HTTPCLIENT-2219
+                // See https://issues.apache.org/jira/browse/HTTPCLIENT-2219
                 .setTlsDetailsFactory(new Factory<SSLEngine, TlsDetails>() {
                     @Override
                     public TlsDetails create(final SSLEngine sslEngine) {

diff --git a/client/rest/src/test/java/org/opensearch/client/documentation/RestClientDocumentation.java b/client/rest/src/test/java/org/opensearch/client/documentation/RestClientDocumentation.java
@@ -433,7 +433,7 @@ public HttpAsyncClientBuilder customizeHttpClient(
                             HttpAsyncClientBuilder httpClientBuilder) {
                         final TlsStrategy tlsStrategy = ClientTlsStrategyBuilder.create()
                                 .setSslContext(sslContext)
-                                // See please https://issues.apache.org/jira/browse/HTTPCLIENT-2219
+                                // See https://issues.apache.org/jira/browse/HTTPCLIENT-2219
                                 .setTlsDetailsFactory(new Factory<SSLEngine, TlsDetails>() {
                                     @Override
                                     public TlsDetails create(final SSLEngine sslEngine) {

diff --git a/modules/reindex/src/main/java/org/opensearch/index/reindex/ReindexSslConfig.java b/modules/reindex/src/main/java/org/opensearch/index/reindex/ReindexSslConfig.java
@@ -182,7 +182,7 @@ TlsStrategy getStrategy() {
             .setHostnameVerifier(hostnameVerifier)
             .setCiphers(cipherSuites)
             .setTlsVersions(protocols)
-            // See please https://issues.apache.org/jira/browse/HTTPCLIENT-2219
+            // See https://issues.apache.org/jira/browse/HTTPCLIENT-2219
             .setTlsDetailsFactory(new Factory<SSLEngine, TlsDetails>() {
                 @Override
                 public TlsDetails create(final SSLEngine sslEngine) {

diff --git a/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java b/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java
@@ -857,7 +857,7 @@ protected static void configureClient(RestClientBuilder builder, Settings settin
                 builder.setHttpClientConfigCallback(httpClientBuilder -> {
                     final TlsStrategy tlsStrategy = ClientTlsStrategyBuilder.create()
                         .setSslContext(sslcontext)
-                        // See please https://issues.apache.org/jira/browse/HTTPCLIENT-2219
+                        // See https://issues.apache.org/jira/browse/HTTPCLIENT-2219
                         .setTlsDetailsFactory(new Factory<SSLEngine, TlsDetails>() {
                             @Override
                             public TlsDetails create(final SSLEngine sslEngine) {