handle empty bitmap rewrite scenarios

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
opensearch-project · Aug 8, 2024 · c51dfc8 · c51dfc8
1 parent 8e1feb0
commit c51dfc8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java b/server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java
@@ -46,6 +46,7 @@
 import org.apache.lucene.sandbox.document.HalfFloatPoint;
 import org.apache.lucene.search.BoostQuery;
 import org.apache.lucene.search.IndexOrDocValuesQuery;
+import org.apache.lucene.search.IndexSearcher;
 import org.apache.lucene.search.IndexSortSortedNumericDocValuesRangeQuery;
 import org.apache.lucene.search.MatchNoDocsQuery;
 import org.apache.lucene.search.PointInSetQuery;
@@ -1463,6 +1464,14 @@ public BytesRef next() {
                     return encoded;
                 }
             }) {
+                @Override
+                public Query rewrite(IndexSearcher indexSearcher) throws IOException {
+                    if (bitmap.isEmpty()) {
+                        return new MatchNoDocsQuery();
+                    }
+                    return super.rewrite(indexSearcher);
+                }
+
                 @Override
                 protected String toString(byte[] value) {
                     assert value.length == Integer.BYTES;

diff --git a/server/src/main/java/org/opensearch/search/query/BitmapDocValuesQuery.java b/server/src/main/java/org/opensearch/search/query/BitmapDocValuesQuery.java
@@ -45,8 +45,13 @@ public class BitmapDocValuesQuery extends Query implements Accountable {
     public BitmapDocValuesQuery(String field, RoaringBitmap bitmap) {
         this.field = field;
         this.bitmap = bitmap;
-        min = bitmap.first();
-        max = bitmap.last();
+        if (!bitmap.isEmpty()) {
+            min = bitmap.first();
+            max = bitmap.last();
+        } else {
+            min = 0; // final field
+            max = 0;
+        }
     }
 
     @Override
@@ -112,7 +117,7 @@ public String toString(String field) {
 
     @Override
     public Query rewrite(IndexSearcher indexSearcher) throws IOException {
-        if (bitmap.getLongCardinality() == 0) {
+        if (bitmap.isEmpty()) {
             return new MatchNoDocsQuery();
         }
         return super.rewrite(indexSearcher);