Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] - SeqNo and Version comparison between shards is not accurate. #6121

Closed
mch2 opened this issue Feb 1, 2023 · 0 comments · Fixed by #6122
Closed

[Segment Replication] - SeqNo and Version comparison between shards is not accurate. #6121

mch2 opened this issue Feb 1, 2023 · 0 comments · Fixed by #6122
Assignees
Labels
bug Something isn't working untriaged

Comments

@mch2
Copy link
Member

mch2 commented Feb 1, 2023

The seqNo that is currently sent to replicas from the primary shard is its processed checkpoint. This is fetched close to when the latest infos are fetched, but does not guarantee that this seqNo is the max seqNo from the copied SegmentInfos. We need to update this to query for the max seqNo using changes introduced in #5970.

Further, the version number on replica's SegmentInfos is incorrectly increased when it performs a commit. This will incorrectly force the replica to ignore incoming checkpoints from the primary if the SegmentInfos version is only increased by 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant