Update replicationCheckpoint to include accurate seqNo from SegmentInfos. #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mch2
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
mch2
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Gradle Check (Jenkins) Run Completed with:
|
dreamer-89
reviewed
Feb 2, 2023
…SegmentInfos. This change updates IndexShard#getlatestSegmentInfos to include the latest max seqNo from the primary's segmentInfos snapshot. It also updates the method to return a Tuple so that both can be fetched. This change also updates replicas to not bump their SegmentInfos version when performing a commit. Signed-off-by: Marc Handalian <handalm@amazon.com>
dreamer-89
approved these changes
Feb 2, 2023
…itSegmentInfos. Signed-off-by: Marc Handalian <handalm@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6122 +/- ##
============================================
- Coverage 70.74% 70.72% -0.02%
+ Complexity 58752 58716 -36
============================================
Files 4776 4776
Lines 280990 280993 +3
Branches 40596 40598 +2
============================================
- Hits 198774 198735 -39
- Misses 65876 65910 +34
- Partials 16340 16348 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6122-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c5a1bdfbfa2f2baab6f100cccd47db2e709e733a
# Push it to GitHub
git push --set-upstream origin backport/backport-6122-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Feb 2, 2023
…fos. (opensearch-project#6122) * Update replicationCheckpoint to include accurate seqNo from provided SegmentInfos. This change updates IndexShard#getlatestSegmentInfos to include the latest max seqNo from the primary's segmentInfos snapshot. It also updates the method to return a Tuple so that both can be fetched. This change also updates replicas to not bump their SegmentInfos version when performing a commit. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add missing test to StoreTests verifying version and userData on commitSegmentInfos. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit c5a1bdf)
dreamer-89
pushed a commit
that referenced
this pull request
Feb 2, 2023
…fos. (#6122) (#6156) * Update replicationCheckpoint to include accurate seqNo from provided SegmentInfos. This change updates IndexShard#getlatestSegmentInfos to include the latest max seqNo from the primary's segmentInfos snapshot. It also updates the method to return a Tuple so that both can be fetched. This change also updates replicas to not bump their SegmentInfos version when performing a commit. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add missing test to StoreTests verifying version and userData on commitSegmentInfos. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com> (cherry picked from commit c5a1bdf)
andrross
added a commit
to andrross/OpenSearch
that referenced
this pull request
Feb 3, 2023
Three changes here: - Remove unneeded entry (was removed in backport) (opensearch-project#6049) - Move segrep change to proper section (was put in correct spot in backport) (opensearch-project#6122) - Add back issue that was merged to main prior to 2.5 release but not backported, and was therefore removed from the main CHANGELOG (opensearch-project#4603) Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
added a commit
that referenced
this pull request
Feb 4, 2023
Three changes here: - Remove unneeded entry (was removed in backport) (#6049) - Move segrep change to proper section (was put in correct spot in backport) (#6122) - Add back issue that was merged to main prior to 2.5 release but not backported, and was therefore removed from the main CHANGELOG (#4603) Signed-off-by: Andrew Ross <andrross@amazon.com>
mch2
added a commit
to mch2/OpenSearch
that referenced
this pull request
Mar 4, 2023
…fos. (opensearch-project#6122) * Update replicationCheckpoint to include accurate seqNo from provided SegmentInfos. This change updates IndexShard#getlatestSegmentInfos to include the latest max seqNo from the primary's segmentInfos snapshot. It also updates the method to return a Tuple so that both can be fetched. This change also updates replicas to not bump their SegmentInfos version when performing a commit. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add missing test to StoreTests verifying version and userData on commitSegmentInfos. Signed-off-by: Marc Handalian <handalm@amazon.com> --------- Signed-off-by: Marc Handalian <handalm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Handalian handalm@amazon.com
Description
This change updates IndexShard#getlatestSegmentInfos to include the latest max seqNo from the primary's segmentInfos snapshot. It also updates the method to return a Tuple so that both can be fetched. This change also updates replicas to not bump their SegmentInfos version when performing a commit.
Issues Resolved
closes #6121
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.