Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing instrumentation in transport service #10042

Merged

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Sep 14, 2023

Description

Add tracing instrumentation in transport service.

Related Issues

Resolves #8553

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions github-actions bot added distributed framework enhancement Enhancement or improvement to existing feature or request labels Sep 14, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Compatibility status:

Checks if related components are compatible with change 0133a16

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #10042 (0133a16) into main (921cd0c) will increase coverage by 0.72%.
Report is 6 commits behind head on main.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main   #10042      +/-   ##
============================================
+ Coverage     70.42%   71.14%   +0.72%     
- Complexity    57451    58130     +679     
============================================
  Files          4824     4825       +1     
  Lines        273918   273952      +34     
  Branches      39918    39918              
============================================
+ Hits         192894   194900    +2006     
+ Misses        64725    62726    -1999     
- Partials      16299    16326      +27     
Files Changed Coverage Δ
...opensearch/transport/TransportResponseHandler.java 0.00% <0.00%> (ø)
...ava/org/opensearch/transport/TransportService.java 79.61% <80.00%> (+0.32%) ⬆️
...ing/handler/TraceableTransportResponseHandler.java 83.33% <83.33%> (ø)

... and 572 files with indirect coverage changes

@Gaganjuneja
Copy link
Contributor Author

@reta, I have fixed the failing test cases. Please take a look.

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 v2.11.0 Issues and PRs related to version 2.11.0 labels Sep 15, 2023
@reta reta merged commit 483c2e3 into opensearch-project:main Sep 15, 2023
19 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Sep 15, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10042-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 483c2e36f6c8f2e326279b3b0e598d21072bdc14
# Push it to GitHub
git push --set-upstream origin backport/backport-10042-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10042-to-2.x.

@reta
Copy link
Collaborator

reta commented Sep 15, 2023

@Gaganjuneja could you please backport manually to 2.x? thank you

Gaganjuneja added a commit to Gaganjuneja/OpenSearch that referenced this pull request Sep 15, 2023
…10042)

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
reta pushed a commit that referenced this pull request Sep 15, 2023
* Add instrumentation to transport service



* Add instrumentation to transport service



* Add javadoc



---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
…10042)

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…10042)

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…10042)

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…10042)

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add instrumentation to transport service

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add javadoc

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed distributed framework enhancement Enhancement or improvement to existing feature or request v2.11.0 Issues and PRs related to version 2.11.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracing Instrumentation] Adds instrumentation at Transport Layer level
2 participants