-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remove ingest processor handing ignore_missing parameter not correctly #10089
Fix remove ingest processor handing ignore_missing parameter not correctly #10089
Conversation
…ectly Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 2042c87 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/k-nn.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
modules/ingest-common/src/test/java/org/opensearch/ingest/common/RemoveProcessorTests.java
Outdated
Show resolved
Hide resolved
modules/ingest-common/src/test/java/org/opensearch/ingest/common/RemoveProcessorTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
modules/ingest-common/src/test/java/org/opensearch/ingest/common/RemoveProcessorTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
modules/ingest-common/src/test/java/org/opensearch/ingest/common/RemoveProcessorTests.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10089 +/- ##
============================================
- Coverage 71.22% 71.02% -0.20%
+ Complexity 58240 58138 -102
============================================
Files 4828 4828
Lines 274419 274423 +4
Branches 39989 39991 +2
============================================
- Hits 195443 194905 -538
- Misses 62574 63195 +621
+ Partials 16402 16323 -79
|
…ectly (#10089) * Fix remove ingest processor handing ignore_missing parameter not correctly Signed-off-by: Gao Binlong <gbinlong@amazon.com> * modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure and optimize some code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Minor change Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify test code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Split a test method to two Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit c44337e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ectly (#10089) (#10218) * Fix remove ingest processor handing ignore_missing parameter not correctly * modify change log * Fix test failure and optimize some code * Minor change * Modify test code * Split a test method to two --------- (cherry picked from commit c44337e) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ectly (opensearch-project#10089) * Fix remove ingest processor handing ignore_missing parameter not correctly Signed-off-by: Gao Binlong <gbinlong@amazon.com> * modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure and optimize some code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Minor change Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify test code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Split a test method to two Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…ectly (opensearch-project#10089) * Fix remove ingest processor handing ignore_missing parameter not correctly Signed-off-by: Gao Binlong <gbinlong@amazon.com> * modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure and optimize some code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Minor change Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify test code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Split a test method to two Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…ectly (opensearch-project#10089) * Fix remove ingest processor handing ignore_missing parameter not correctly Signed-off-by: Gao Binlong <gbinlong@amazon.com> * modify change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure and optimize some code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Minor change Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify test code Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Split a test method to two Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Remove ingest processor does not handle
ignore_missing
parameter correctly, when the resolved filed path of template snippet like{{field}}
is empty string andignore_missing
istrue
, the processor does not exit quietly, but throw anillegal_argument_exception
, this should be a bug.The main change of this PR:
Related Issues
#10066
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.