Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository stats for remote store #10567

Merged
merged 10 commits into from
Oct 18, 2023

Conversation

Bukhtawar
Copy link
Collaborator

@Bukhtawar Bukhtawar commented Oct 11, 2023

Description

Adds repository stats for remote store

Related Issues

#8917

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Compatibility status:

Checks if related components are compatible with change aecc8b1

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@Bukhtawar Bukhtawar marked this pull request as ready for review October 13, 2023 18:26
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #10567 (aecc8b1) into main (9cc0e7d) will decrease coverage by 0.12%.
Report is 3 commits behind head on main.
The diff coverage is 41.48%.

@@             Coverage Diff              @@
##               main   #10567      +/-   ##
============================================
- Coverage     71.23%   71.12%   -0.12%     
+ Complexity    58571    58464     -107     
============================================
  Files          4853     4854       +1     
  Lines        275796   275864      +68     
  Branches      40139    40147       +8     
============================================
- Hits         196458   196199     -259     
- Misses        62925    63251     +326     
- Partials      16413    16414       +1     
Files Coverage Δ
...rg/opensearch/repositories/s3/S3BlobContainer.java 81.25% <100.00%> (+2.61%) ⬆️
...ch/repositories/s3/async/AsyncTransferManager.java 83.67% <100.00%> (+0.22%) ⬆️
...on/admin/cluster/node/stats/NodesStatsRequest.java 93.50% <100.00%> (+0.08%) ⬆️
.../cluster/node/stats/TransportNodesStatsAction.java 100.00% <100.00%> (ø)
...min/cluster/stats/TransportClusterStatsAction.java 69.56% <ø> (ø)
server/src/main/java/org/opensearch/node/Node.java 85.18% <ø> (ø)
...nsearch/repositories/RepositoriesStatsArchive.java 100.00% <ø> (+7.50%) ⬆️
...sitories/blobstore/MeteredBlobStoreRepository.java 66.66% <100.00%> (-17.95%) ⬇️
...pensearch/common/blobstore/EncryptedBlobStore.java 0.00% <0.00%> (ø)
...g/opensearch/repositories/RepositoriesService.java 66.93% <50.00%> (-0.52%) ⬇️
... and 10 more

... and 458 files with indirect coverage changes

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna gbbafna merged commit 1715da5 into opensearch-project:main Oct 18, 2023
15 of 16 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 18, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10567-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1715da57f5c6223bf590118bf5adad8a7afaf9da
# Push it to GitHub
git push --set-upstream origin backport/backport-10567-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10567-to-2.x.

gbbafna pushed a commit to gbbafna/OpenSearch that referenced this pull request Oct 18, 2023
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
gbbafna added a commit that referenced this pull request Oct 19, 2023
* Repository stats for remote store (#10567)

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>

* Changing version for repo stats blob

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* spotless fixes

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

* Muting s3 request stats test (#10736)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>

---------

Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Co-authored-by: Bukhtawar Khan <bukhtawa@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants