Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix dissect ingest processor parsing empty brackets failed #10667

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7b62e2f from #9255.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Compatibility status:

Checks if related components are compatible with change 6ccb649

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ca8b54c) 71.10% compared to head (6ccb649) 71.05%.
Report is 77 commits behind head on 2.x.

Files Patch % Lines
...ain/java/org/opensearch/dissect/DissectParser.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #10667      +/-   ##
============================================
- Coverage     71.10%   71.05%   -0.06%     
+ Complexity    59204    59124      -80     
============================================
  Files          4869     4869              
  Lines        278732   278738       +6     
  Branches      40848    40849       +1     
============================================
- Hits         198196   198049     -147     
- Misses        63786    63989     +203     
+ Partials      16750    16700      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gaobinlong
Copy link
Collaborator

@dblock ,could you help to review this backport PR?

@dblock
Copy link
Member

dblock commented Nov 21, 2023

@gaobinlong Please take a look at Gradle check failures, call out flakes and such.

@dblock
Copy link
Member

dblock commented Nov 21, 2023

For some reason GH is not letting me restart the gradle check either, force push an update?

@gaobinlong
Copy link
Collaborator

Existing flaky tests: #8932, I've created a new issue for another failed test: #11299.

@gaobinlong
Copy link
Collaborator

@dblock I cannot update the backport branch because this PR was created by the bot, I don't have permission.

@dblock
Copy link
Member

dblock commented Nov 26, 2023

I am not sure why, but GitHub UX no longer lets me restart this gradle check. Re-create the backport by hand please, sorry.

* Fix dissect ingest processor parsing empty brackets failed

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Add assertion

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit 7b62e2f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross
Copy link
Member

@gaobinlong I rebased this PR from 2.x and pushed an update

Copy link
Contributor

❕ Gradle check result for 6ccb649: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gaobinlong
Copy link
Collaborator

@gaobinlong I rebased this PR from 2.x and pushed an update

Thanks @andrross , the failed test is flaky, and there's an issue. The check result becomes green, I think this PR can be merged now.

@opensearch-trigger-bot
Copy link
Contributor Author

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jan 7, 2024
@ticheng-aws
Copy link
Contributor

Hi @gaobinlong, @dblock, and @andrross, the PR is stalled. Is this being worked upon?

@ticheng-aws ticheng-aws added the bug Something isn't working label Jan 7, 2024
@gaobinlong
Copy link
Collaborator

I think this PR is ready to merge, please help to merge, @dblock @andrross thanks!

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 8, 2024
@dblock dblock merged commit 334636f into 2.x Jan 9, 2024
27 checks passed
@github-actions github-actions bot deleted the backport/backport-9255-to-2.x branch January 9, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants