Revert "Validate checksum of each segment file post download from remote store (#10119)"

[sachinpkale]

Description

• This reverts commit 6c02261.
• The change has significant impact on the performance in the download segment flow.
• For now, relying on configured remote store's in-built checksum validation.
• We will re-visit this once we have better idea on perf and potential optimizations.

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ashking94]

DCO is missing, pls recommit.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 9d5a748

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

• URL: https://build.ci.opensearch.org/job/gradle-check/28786/
• CommitID: 1264487
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10847 (9d5a748) into main (51626d0) will decrease coverage by 0.14%.
Report is 13 commits behind head on main.
The diff coverage is 90.86%.

@@             Coverage Diff              @@
##               main   #10847      +/-   ##
============================================
- Coverage     71.31%   71.18%   -0.14%     
- Complexity    58671    58674       +3     
============================================
  Files          4860     4869       +9     
  Lines        276335   276421      +86     
  Branches      40198    40196       -2     
============================================
- Hits         197068   196760     -308     
- Misses        62803    63236     +433     
+ Partials      16464    16425      -39     

Files	Coverage Δ
...upport/replication/TransportReplicationAction.java	77.99% <100.00%> (-2.69%)	⬇️
...ava/org/opensearch/cluster/node/DiscoveryNode.java	91.62% <100.00%> (+0.17%)	⬆️
...a/org/opensearch/common/network/NetworkModule.java	92.20% <100.00%> (+0.20%)	⬆️
...rg/opensearch/common/settings/ClusterSettings.java	92.85% <ø> (ø)
.../java/org/opensearch/gateway/GatewayMetaState.java	68.01% <100.00%> (-0.51%)	⬇️
...earch/index/remote/RemoteStorePressureService.java	100.00% <ø> (ø)
...earch/index/store/RemoteSegmentStoreDirectory.java	88.84% <ø> (-1.12%)	⬇️
...rc/main/java/org/opensearch/index/store/Store.java	81.10% <100.00%> (+0.66%)	⬆️
server/src/main/java/org/opensearch/node/Node.java	85.31% <100.00%> (+0.09%)	⬆️
...ting/admissioncontrol/AdmissionControlService.java	100.00% <100.00%> (ø)
... and 15 more

... and 462 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28787/
• CommitID: 9d5a748
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

• URL: https://build.ci.opensearch.org/job/gradle-check/28808/
• CommitID: 9d5a748
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.