Fix remote shards balancer and remove unused variables

[bugmakerrrrrr]

Description

Two changes here:

• make sure the primary shard's AllocationStatus be set to DECIDERS_NO when it cannot be allocated to any nodes;
• remove unused variables

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 5ce38e5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

Compatibility status:

Checks if related components are compatible with change 351649a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

[bugmakerrrrrr]

@kotwanikunal can you take a look at this when you are available

[bugmakerrrrrr]

Thanks @bugmakerrrrrr!

make sure the primary shard's AllocationStatus be set to DECIDERS_NO when it cannot be allocated to any nodes

This sounds like a bug. Can you provide details about when this can occur and how this change fixes it?

Yes, this bug occurs when all deciders return NO for each node, because we always set the throttled flag after iterating all nodes.

OpenSearch/server/src/main/java/org/opensearch/cluster/routing/allocation/allocator/RemoteShardsBalancer.java

Line 447 in b974dfb

throttled = true;

I just delete this statement to fix it.

[kotwanikunal]

@kotwanikunal can you take a look at this when you are available

I just got back today. I will take a look at it shortly

[kotwanikunal]

@bugmakerrrrrr LGTM. Do you mind adding in a changelog entry? I can re-run the gradle check as it looks unrelated.

#11179

@sohami would be great to have a review from you as well!

[github-actions]

✅ Gradle check result for 2f962ba: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50e3666) 71.37% compared to head (351649a) 71.34%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11167      +/-   ##
============================================
- Coverage     71.37%   71.34%   -0.04%     
+ Complexity    59102    59067      -35     
============================================
  Files          4893     4893              
  Lines        277754   277751       -3     
  Branches      40356    40356              
============================================
- Hits         198242   198148      -94     
- Misses        63066    63125      +59     
- Partials      16446    16478      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bugmakerrrrrr]

@kotwanikunal done

[github-actions]

❌ Gradle check result for d17f525: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[sohami]

Lgtm. Without the fix it will leave the unassigned shards with reason as throttled whereas in reality it was not eligible to be assigned on any of the available remote capable nodes

[github-actions]

❕ Gradle check result for d17f525: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[kotwanikunal]

@bugmakerrrrrr Can you please rebase? :)

[bugmakerrrrrr]

@bugmakerrrrrr Can you please rebase? :)

done

[github-actions]

❕ Gradle check result for 351649a: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.