Updating Ip fields to use doc_values to search #11508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
harshavamsi
force-pushed
the
ipfield_iodvq
branch
from
4b2b0c5
to
f15a2ae
Compare
Compatibility status:Checks if related components are compatible with change 407b723 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
|
❌ Gradle check result for 4b2b0c5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f15a2ae: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
harshavamsi
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
peternied,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale and
saratvemulapalli
as code owners
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
harshavamsi
force-pushed
the
ipfield_iodvq
branch
from
ef9b400
to
407b723
Compare
|
❕ Gradle check result for 407b723: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
msfroh
approved these changes
Jan 29, 2024
|
@andrross LGTY? :-) |
andrross
approved these changes
Jan 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Spotless Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> (cherry picked from commit cc9ee9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh
approved these changes
Jan 30, 2024
reta
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Spotless Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> (cherry picked from commit cc9ee9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Jan 30, 2024
* Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Spotless Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> (cherry picked from commit cc9ee9d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Updating Ip fields to use doc_values to search * Fix IP tests * Fix skip to allow yaml test to pass on main * Update tests to use existing test file * Changing skip version to match bwc * Using exact match instead of range * Spotless * Fix IP field tests * Fix spotless + precommit failure * Get point out of query and into value * Fix term tests * Add skip test logic to only doc_values test --------- (cherry picked from commit cc9ee9d) Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Mar 1, 2024
) * Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Spotless Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
rayshrey
pushed a commit
to rayshrey/OpenSearch
that referenced
this pull request
Mar 18, 2024
) * Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Spotless Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
) * Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Spotless Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> --------- Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
|
I'm afraid there is an edge case cc9ee9d#r148997353 |
@mkhludnev -- are you able to fix that as part of #16391 ? If not, we can open a separate issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
termandrangequeries onIpFieldsto be able to perform searches when onlydoc_valuesis enabled.Related Issues
Resolves #11144
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.