Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert issue and bug templates to use forms #11534

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Dec 8, 2023

Description

This converts bug and feature request templates to forms that require users to select a label. The added workflow will trigger after the issue cut and apply the actual label to the issue based on the value selected.

This is a continuation of #11178 cherry picked from @bowenlan-amzn's fork.

The commit I added sorts the label values and adds a description alerting users to select "Other" if they don't know which label to select.

Tested both on my fork with these issues:
Feature request
Bug

Related Issues

Resolves #10901

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mch2
Copy link
Member Author

mch2 commented Dec 8, 2023

@msfroh Saw you had started reviewing #11178 - mind taking a look here?

@kotwanikunal
Copy link
Member

While we are at it - Do you think it makes sense to add in a flaky test form as well?

This comment was marked as outdated.

@mch2
Copy link
Member Author

mch2 commented Dec 11, 2023

I forgot I had cut this from main so that i could test it from my fork and reset that branch causing this to get closed. Should be restored now - @anasalkouz mind taking another look before this is merged?

@mch2 mch2 requested a review from anasalkouz December 11, 2023 19:05

This comment was marked as outdated.

Copy link
Contributor

❌ Gradle check result for f7cdfaf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5102640: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Copy link
Contributor

❌ Gradle check result for 821ad93: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2
Copy link
Member Author

mch2 commented Dec 11, 2023

❕ Gradle check result for 56d4abd: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

#10558

@mch2
Copy link
Member Author

mch2 commented Dec 11, 2023

❌ Gradle check result for 5102640: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#11581

❌ Gradle check result for f7cdfaf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#1703

@mch2
Copy link
Member Author

mch2 commented Dec 11, 2023

❌ Gradle check result for 5102640: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#9191

@mch2 mch2 requested a review from peternied December 11, 2023 22:25
Copy link
Contributor

❌ Gradle check result for e4a1e03: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 78bc13d: SUCCESS

Copy link
Contributor

❌ Gradle check result for ac8eab6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for ac8eab6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peternied peternied self-assigned this Dec 13, 2023
@andrross
Copy link
Member

@peternied I see you self-assigned this. Do you want to review/approve it?

@peternied
Copy link
Member

@peternied I see you self-assigned this. Do you want to review/approve it?

Thanks for checking in @andrross - I have been adding myself as 'assigned' to make it easier to track PRs that I'm actively reviewing - but I won't mind if it was merged since I didn't request changes. 🤞 this workflow won't be need after the personalization changes [1] are in.

@peternied peternied merged commit bb67196 into opensearch-project:main Dec 13, 2023
38 checks passed
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authors to assign component's label
6 participants