-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support index level allocation filtering for searchable snapshot index #11563
Support index level allocation filtering for searchable snapshot index #11563
Conversation
❌ Gradle check result for 15d2358: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
15d2358
to
1997226
Compare
❕ Gradle check result for 1997226: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11563 +/- ##
============================================
- Coverage 71.38% 70.70% -0.68%
+ Complexity 59354 58774 -580
============================================
Files 4923 4911 -12
Lines 279095 278674 -421
Branches 40559 40534 -25
============================================
- Hits 199228 197043 -2185
- Misses 63292 65191 +1899
+ Partials 16575 16440 -135 ☔ View full report in Codecov by Sentry. |
@kotwanikunal Could you please have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
.../src/main/java/org/opensearch/cluster/routing/allocation/allocator/RemoteShardsBalancer.java
Outdated
Show resolved
Hide resolved
1997226
to
1a59be8
Compare
❌ Gradle check result for 1a59be8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@kotwanikunal all relevant issues fixed |
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
1a59be8
to
9925816
Compare
I just pushed a rebase from main and fixed the conflict in the changelog |
❌ Gradle check result for 1a59be8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 9925816: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
#11563) * support index level allocation filtering Signed-off-by: panguixin <panguixin@bytedance.com> * run spotless Signed-off-by: panguixin <panguixin@bytedance.com> * fix IT Signed-off-by: panguixin <panguixin@bytedance.com> * fix not statement and add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit 2f81c57) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#11563) * support index level allocation filtering Signed-off-by: panguixin <panguixin@bytedance.com> * run spotless Signed-off-by: panguixin <panguixin@bytedance.com> * fix IT Signed-off-by: panguixin <panguixin@bytedance.com> * fix not statement and add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit 2f81c57) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#11563) * support index level allocation filtering Signed-off-by: panguixin <panguixin@bytedance.com> * run spotless Signed-off-by: panguixin <panguixin@bytedance.com> * fix IT Signed-off-by: panguixin <panguixin@bytedance.com> * fix not statement and add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit 2f81c57) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
#11563) (#11927) * support index level allocation filtering * run spotless * fix IT * fix not statement and add change log --------- (cherry picked from commit 2f81c57) Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project#11563) * support index level allocation filtering Signed-off-by: panguixin <panguixin@bytedance.com> * run spotless Signed-off-by: panguixin <panguixin@bytedance.com> * fix IT Signed-off-by: panguixin <panguixin@bytedance.com> * fix not statement and add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com>
opensearch-project#11563) * support index level allocation filtering Signed-off-by: panguixin <panguixin@bytedance.com> * run spotless Signed-off-by: panguixin <panguixin@bytedance.com> * fix IT Signed-off-by: panguixin <panguixin@bytedance.com> * fix not statement and add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com>
opensearch-project#11563) * support index level allocation filtering Signed-off-by: panguixin <panguixin@bytedance.com> * run spotless Signed-off-by: panguixin <panguixin@bytedance.com> * fix IT Signed-off-by: panguixin <panguixin@bytedance.com> * fix not statement and add change log Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Two changes here:
OpenSearch/server/src/main/java/org/opensearch/index/shard/IndexShard.java
Line 604 in 6bb53de
Related Issues
Resolves #11468
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.