Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only intersecting buckets to the Adjacency matrix aggregation #11733

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

brusic
Copy link

@brusic brusic commented Jan 3, 2024

Re-release of a previous PR that did not correctly sign the commit

Description

Show only intersecting buckets to the Adjacency matrix aggregation

The Adjacency matrix aggregation will compute and return all buckets related to any of the combinations of the filters specified, including hits on a single filter. However, sometimes a user would want to return only the buckets related to an intersection and not for a single filter. An optional show_only_intersecting parameter would stop buckets resulting from a single filter being hit to be created.

Related Issues

#8832

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Compatibility status:

Checks if related components are compatible with change dc5897b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Gradle check result for 68d1746: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@brusic
Copy link
Author

brusic commented Jan 3, 2024

Apparently failed with > Task :qa:wildfly:spotlessMisc FAILED, but it is working locally using jdk11. No issues mentioning a flaky test.

Jenkins error

* What went wrong:
A problem was found with the configuration of task ':qa:wildfly:spotlessMisc' (type 'SpotlessTaskImpl').
  - Gradle detected a problem with the following location: '/var/jenkins/workspace/gradle-check/search/qa/wildfly'.
    
    Reason: Task ':qa:wildfly:spotlessMisc' uses this output of task ':qa:wildfly:preProcessFixture' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':qa:wildfly:preProcessFixture' as an input of ':qa:wildfly:spotlessMisc'.
      2. Declare an explicit dependency on ':qa:wildfly:preProcessFixture' from ':qa:wildfly:spotlessMisc' using Task#dependsOn.
      3. Declare an explicit dependency on ':qa:wildfly:preProcessFixture' from ':qa:wildfly:spotlessMisc' using Task#mustRunAfter.

Local execution

% ./gradlew :qa:wildfly:spotlessMisc      

> Configure project :
========================= WARNING =========================
         Backwards compatibility tests are disabled!
See https://github.com/opensearch-project/OpenSearch/issues/4173
===========================================================
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.5
  OS Info               : Mac OS X 13.4.1 (x86_64)
  JDK Version           : 11 (Homebrew JDK)
  JAVA_HOME             : /usr/local/Cellar/openjdk@11/11.0.21/libexec/openjdk.jdk/Contents/Home
  Random Testing Seed   : 4202A040C72920CD
  In FIPS 140 mode      : false
=======================================

BUILD SUCCESSFUL in 7s
10 actionable tasks: 1 executed, 9 up-to-date

% ./gradlew :qa:wildfly:preProcessFixture

> Configure project :
========================= WARNING =========================
         Backwards compatibility tests are disabled!
See https://github.com/opensearch-project/OpenSearch/issues/4173
===========================================================
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.5
  OS Info               : Mac OS X 13.4.1 (x86_64)
  JDK Version           : 11 (Homebrew JDK)
  JAVA_HOME             : /usr/local/Cellar/openjdk@11/11.0.21/libexec/openjdk.jdk/Contents/Home
  Random Testing Seed   : E8272F8D6651F238
  In FIPS 140 mode      : false
=======================================

BUILD SUCCESSFUL in 6s
189 actionable tasks: 3 executed, 186 up-to-date

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Feb 3, 2024
@brusic brusic force-pushed the brusic/8832-show-only-intersecting-adjacency branch from 68d1746 to 93a40c5 Compare April 3, 2024 00:37
Copy link
Contributor

github-actions bot commented Apr 3, 2024

❌ Gradle check result for 93a40c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Apr 3, 2024
brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 1702b2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 7ce967a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 4, 2024
Signed-off-by: Ivan Brusic <ivan@brusic.com>
brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 4, 2024
Signed-off-by: Ivan Brusic <ivan@brusic.com>
@brusic brusic force-pushed the brusic/8832-show-only-intersecting-adjacency branch from 7ce967a to 441ed4f Compare April 4, 2024 01:31
brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 4, 2024
Signed-off-by: Ivan Brusic <ivan@brusic.com>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 441ed4f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for ad93f2d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 4, 2024
…ex: 80] (Euro sign) (opensearch-project#11733)

Signed-off-by: Ivan Brusic <ivan@brusic.com>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for 8b77d0d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

brusic added a commit to brusic/OpenSearch that referenced this pull request Apr 4, 2024
Signed-off-by: Ivan Brusic <ivan@brusic.com>
Copy link
Contributor

github-actions bot commented Apr 4, 2024

❌ Gradle check result for dc5897b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label May 7, 2024
brusic and others added 6 commits June 11, 2024 17:38
Signed-off-by: Ivan Brusic <ivan@brusic.com>
Signed-off-by: Ivan Brusic <ivan@brusic.com>
Signed-off-by: Ivan Brusic <ivan@brusic.com>
Signed-off-by: Ivan Brusic <ivan@brusic.com>
…ex: 80] (Euro sign) (opensearch-project#11733)

Signed-off-by: Ivan Brusic <ivan@brusic.com>
Signed-off-by: Ivan Brusic <ivan@brusic.com>
@brusic brusic force-pushed the brusic/8832-show-only-intersecting-adjacency branch from dc5897b to 3ac882e Compare June 12, 2024 00:39
Copy link
Contributor

❌ Gradle check result for 3ac882e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant