Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for AdmissionControl Interceptor and AdmissionControlSe… #11965

Closed
wants to merge 4 commits into from

Conversation

ajaymovva
Copy link
Contributor

@ajaymovva ajaymovva commented Jan 22, 2024

Description

Backport of PR: #9286

Related Issues

RFC: #8910
META Issue: #9504

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Compatibility status:

Checks if related components are compatible with change 87c2b50

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

❌ Gradle check result for 8086c35: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 36a72b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7cab2da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for ced059a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=pit/10_basic/Delete all}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (7e3c080) 71.16% compared to head (87c2b50) 71.09%.
Report is 4 commits behind head on 2.x.

Files Patch % Lines
...ava/org/opensearch/index/mapper/IpFieldMapper.java 65.71% 10 Missing and 2 partials ⚠️
...ing/admissioncontrol/AdmissionControlSettings.java 90.90% 1 Missing ⚠️
...issioncontrol/controllers/AdmissionController.java 88.88% 1 Missing ⚠️
...ntrol/controllers/CPUBasedAdmissionController.java 90.00% 0 Missing and 1 partial ⚠️
.../settings/CPUBasedAdmissionControllerSettings.java 95.83% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11965      +/-   ##
============================================
- Coverage     71.16%   71.09%   -0.08%     
- Complexity    59481    59505      +24     
============================================
  Files          4894     4903       +9     
  Lines        280242   280397     +155     
  Branches      41107    41115       +8     
============================================
- Hits         199441   199335     -106     
- Misses        63860    64187     +327     
+ Partials      16941    16875      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…rvice for RateLimiting

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Copy link
Contributor

❌ Gradle check result for bd92e1a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for fe431ea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Copy link
Contributor

✅ Gradle check result for f3fbd35: SUCCESS

Copy link
Contributor

❌ Gradle check result for 74760ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f0148e7: SUCCESS

Copy link
Contributor

❌ Gradle check result for d94aa97: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 100976e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for df6ee10: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Gradle check result for 52f10ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 1, 2024

❌ Gradle check result for 3c6a0aa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Copy link
Contributor

github-actions bot commented Feb 1, 2024

❕ Gradle check result for 87c2b50: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.index.shard.RemoteIndexShardTests.testNoFailuresOnFileReads

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@ajaymovva ajaymovva closed this Feb 6, 2024
@ajaymovva ajaymovva deleted the backportAC-2.x branch February 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant