Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky CloseIndexIT.testCloseWhileDeletingIndices #12049

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jan 28, 2024

Description

The test was errorring out due to timeout.

java.lang.AssertionError: Unexpected exception: ProcessClusterEventTimeoutException[failed to process cluster event (add-block-index-to-close [[vquumsvuoq/KiZV1g8bRsWoscd3K-G7Tg]]) within 30s]

Increased the timeout to 60s. 5000 iterations passed locally.

Screenshot of 1000 iterations passing:
image

Related Issues

Resolves #11610

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run labels Jan 28, 2024
@sarthakaggarwal97 sarthakaggarwal97 changed the title Fix Flaky #11610 Fix Flaky CloseIndexIT.testCloseWhileDeletingIndices Jan 28, 2024
Copy link
Contributor

github-actions bot commented Jan 28, 2024

Compatibility status:

Checks if related components are compatible with change d41c3d6

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security.git]

Copy link
Contributor

❌ Gradle check result for 85c7dfb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Copy link
Contributor

❕ Gradle check result for d41c3d6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92afd67) 71.40% compared to head (d41c3d6) 71.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12049      +/-   ##
============================================
- Coverage     71.40%   71.37%   -0.04%     
+ Complexity    59465    59434      -31     
============================================
  Files          4925     4925              
  Lines        279471   279471              
  Branches      40635    40635              
============================================
- Hits         199558   199472      -86     
- Misses        63298    63396      +98     
+ Partials      16615    16603      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross
Copy link
Member

Increased the timeout to 60s. 5000 iterations passed locally.

@sarthakaggarwal97 Could you reliably reproduce this error within 5000 iterations in your local testing before increasing the timeout?

@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Jan 31, 2024

@andrross, yes able to reproduce it currently in the 5000 iterations without the fix. Attaching screenshot for reference.

Screenshot 2024-01-31 at 20 16 14

@andrross andrross added the backport 2.x Backport to 2.x branch label Jan 31, 2024
@andrross andrross merged commit cfcb128 into opensearch-project:main Jan 31, 2024
117 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit cfcb128)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Jan 31, 2024
(cherry picked from commit cfcb128)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Cluster Manager flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CloseIndexIT.testCloseWhileDeletingIndices is flaky
2 participants