Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FilterPath parse function (#12067) #12131

Closed
wants to merge 3 commits into from
Closed

Refactor FilterPath parse function (#12067) #12131

wants to merge 3 commits into from

Conversation

robinf95
Copy link
Contributor

@robinf95 robinf95 commented Feb 1, 2024 •
edited
Loading

Signed-off-by: Robin Friedmann robinfriedmann.rf@gmail.com

Description

Refactoring FilterPath.parse by using an iterative approach instead of recursion.

Related Issues

Resolves #12067

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@robinf95
Refactor FilterPath parse function (opensearch-project#12067)
43f5867 
Signed-off-by: Robin Friedmann <robinfriedmann.rf@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change c154bd7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

❕ Gradle check result for 43f5867: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers labels Feb 1, 2024
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Feb 1, 2024
@deshsidd
Copy link
Contributor

deshsidd commented Feb 1, 2024

Do we have tests covering these already?

@robinf95
Implement unit tests for FilterPathTests (opensearch-project#12067)
d0bb649 
Signed-off-by: Robin Friedmann <robinfriedmann.rf@gmail.com>
@robinf95
Copy link
Contributor Author

robinf95 commented Feb 5, 2024 •
edited
Loading

Do we have tests covering these already?

There are already a bunch of tests FilterPathTests

I just added two that were missing.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for 0be57d1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for 997d2fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@robinf95
Write warn log if Filter is empty; Add comments (opensearch-project#1…
c154bd7 
…2067)

Signed-off-by: Robin Friedmann <robinfriedmann.rf@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for c154bd7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for c154bd7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Mar 8, 2024
@getsaurabh02
Copy link
Member

@deshsidd will you be interested in taking this forward?

@deshsidd
Copy link
Contributor

@deshsidd will you be interested in taking this forward?

Let me take care of this one

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Apr 12, 2024
@sandeshkr419
Copy link
Contributor

@deshsidd Are you still on it?

gaobinlong
gaobinlong reviewed May 14, 2024
View reviewed changes
libs/core/src/test/java/org/opensearch/core/xcontent/filtering/FilterPathTests.java
@@ -369,4 +370,20 @@ public void testMultipleFilterPaths() {
assertThat(filterPath.getSegment(), is(emptyString()));
assertSame(filterPath, FilterPath.EMPTY);
}

public void testCompileWithEmptyString() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this newly added test case is duplicated with the existing test case:

OpenSearch/libs/core/src/test/java/org/opensearch/core/xcontent/filtering/FilterPathTests.java

Line 122 in 14f1c43

public void testEmptyFilterPath() {
.

libs/core/src/test/java/org/opensearch/core/xcontent/filtering/FilterPathTests.java
assertEquals(0, filterPaths.length);
}

public void testCompileWithNull() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same to above, duplicated.

@deshsidd deshsidd mentioned this pull request Jun 11, 2024
Merged
3 tasks
@sandeshkr419
Copy link
Contributor

Closing in lieu of #14200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaobinlong gaobinlong gaobinlong left review comments

@stephen-crawford stephen-crawford stephen-crawford approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@deshsidd deshsidd Awaiting requested review from deshsidd

Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Search Search query, autocomplete ...etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] Replace recursive FilterPath.parse with iterative approach
6 participants
@robinf95 @deshsidd @getsaurabh02 @sandeshkr419 @gaobinlong @stephen-crawford