Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString() to MultiSearchRequest class. #12163

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add toString() to MultiSearchRequest class. #12163

merged 1 commit into from
Feb 12, 2024

Conversation

guillaume-alvarez
Copy link
Contributor

@guillaume-alvarez guillaume-alvarez commented Feb 5, 2024

fix #12144

Description

Make debugging easier with toString() method in MultiSearchRequest class.

Related Issues

Resolves #12144

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Clients Clients within the Core repository such as High level Rest client and low level client labels Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for 0a3c133: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Compatibility status:

Checks if related components are compatible with change 5e4281b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Feb 5, 2024

❌ Gradle check result for cf55045: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 7, 2024

❕ Gradle check result for b51cc07: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Feb 9, 2024

❌ Gradle check result for a5bc1df: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 9, 2024

❌ Gradle check result for 1ed75b9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ Gradle check result for e0df9a6: SUCCESS

Copy link
Contributor

❌ Gradle check result for 7a16ee8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…Request classes.

fix #12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for 5e4281b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@dblock dblock added the backport 2.x Backport to 2.x branch label Feb 12, 2024
@kotwanikunal kotwanikunal merged commit 6823ca1 into opensearch-project:main Feb 12, 2024
38 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12163-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6823ca1291ddcfc63d0704f93990560af1731e3f
# Push it to GitHub
git push --set-upstream origin backport/backport-12163-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12163-to-2.x.

@dblock
Copy link
Member

dblock commented Feb 12, 2024

@guillaume-alvarez will need a manual backport to get this into a 2.x, please?

@guillaume-alvarez
Copy link
Contributor Author

@guillaume-alvarez will need a manual backport to get this into a 2.x, please?

Ok, I created #12314

@guillaume-alvarez guillaume-alvarez deleted the patch-1 branch February 14, 2024 09:08
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…Request classes. (opensearch-project#12163)

fix opensearch-project#12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…Request classes. (opensearch-project#12163)

fix opensearch-project#12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…Request classes. (opensearch-project#12163)

fix opensearch-project#12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Clients Clients within the Core repository such as High level Rest client and low level client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing toString() method in many requests classes
6 participants