Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test cases #12320

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix flaky test cases #12320

merged 1 commit into from
Feb 16, 2024

Conversation

RS146BIJAY
Copy link
Contributor

@RS146BIJAY RS146BIJAY commented Feb 14, 2024 •
edited
Loading

Description

Fixing following test cases:

  1. InternalEngineTests.testUnreferencedFileCleanUpOnSegmentMergeFailureWithCleanUpEnabled: Right now merge policy created for IndexWriter can create an Alcoholic Merge policy as well. This does not sometimes trigger segment merges. Also using ForceMerge policy to avoid regular merge (triggered due to) closing shard before force merge kicks in.
  2. org.opensearch.index.engine.InternalEngineTests.testUnreferencedFileCleanUpOnSegmentMergeFailureWithCleanUpDisabled
  3. InternalEngineTests.testUnreferencedFileCleanUpFailsOnSegmentMergeFailureWhenDirectoryClosed: Right now merge policy created for IndexWriter can create an Alcoholic Merge policy as well. This does not sometimes trigger segment merges.
  4. DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled: Need to refresh DiskThresholdMonitor periodically as well to remove the node from high watermark breached list once available space is above high watermark on all nodes.
  5. ClusterShardLimitIT.testCreateIndexWithMaxClusterShardSetting: Ensure Max shard per cluster is always greater than max shard per node.

Related Issues

#10903
#10739
#9891
#6445
#6287

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0da1a97: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change cfc429a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 045e7c0: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8489294) 71.32% compared to head (cfc429a) 71.35%.
Report is 9 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12320      +/-   ##
============================================
+ Coverage     71.32%   71.35%   +0.03%     
- Complexity    59764    59777      +13     
============================================
  Files          4959     4959              
  Lines        281129   281129              
  Branches      40857    40857              
============================================
+ Hits         200513   200608      +95     
+ Misses        63947    63840     -107     
- Partials      16669    16681      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 506ae7e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@RS146BIJAY RS146BIJAY marked this pull request as ready for review February 15, 2024 07:26
@sachinpkale sachinpkale changed the title Fixing flaky test cases Fix flaky test cases Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for c62d913: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.http.SearchRestCancellationIT.testAutomaticCancellationMultiSearchDuringFetchPhase

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d9f1307: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@RS146BIJAY
Fixing flaky test cases
cfc429a 
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for cfc429a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for cfc429a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@RS146BIJAY
Copy link
Contributor Author

Ran each of the above tests 1000 times without any failures on local

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for cfc429a: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@sachinpkale sachinpkale merged commit 4b51a85 into opensearch-project:main Feb 16, 2024
30 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Feb 16, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 16, 2024
@github-actions
Fixing flaky test cases (#12320)
3eb5c13 
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
(cherry picked from commit 4b51a85)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 16, 2024
Merged
kotwanikunal pushed a commit that referenced this pull request Feb 16, 2024
@opensearch-trigger-bot @github-actions
Fixing flaky test cases (#12320) (#12348)
5d5a998 
(cherry picked from commit 4b51a85)

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peternied peternied mentioned this pull request Feb 29, 2024
Closed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@RS146BIJAY
Fixing flaky test cases (opensearch-project#12320)
e83770b 
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@RS146BIJAY @rayshrey
Fixing flaky test cases (opensearch-project#12320)
d98ea5c 
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@RS146BIJAY @shiv0408
Fixing flaky test cases (opensearch-project#12320)
07c065c 
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkmr kkmr kkmr approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RS146BIJAY @sachinpkale @kkmr