Fix error in RemoteSegmentStoreDirectory when debug logging is enabled #12328

peternied · 2024-02-15T00:10:27Z

Description

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled

Also updated test code to print the exception source for traceability

Related Issues

Discovered in Projected Views #11957

Check List

New functionality includes testing.
- All tests pass
~~New functionality has been documented.~~
- ~~New functionality has javadoc added~~
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>

peternied · 2024-02-15T00:11:52Z

@andrross Could you take a look?

github-actions · 2024-02-15T00:32:39Z

Compatibility status:

Checks if related components are compatible with change 673e4ab

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2024-02-15T01:05:27Z

❌ Gradle check result for 4936736: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-02-15T01:21:34Z

❕ Gradle check result for 8c39071: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-02-15T01:23:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76ae14a) 71.41% compared to head (8c39071) 71.43%.
Report is 8 commits behind head on main.

❗ Current head 8c39071 differs from pull request most recent head 673e4ab. Consider uploading reports for the commit 673e4ab to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12328      +/-   ##
============================================
+ Coverage     71.41%   71.43%   +0.02%     
- Complexity    59813    59820       +7     
============================================
  Files          4959     4959              
  Lines        281126   281126              
  Branches      40857    40857              
============================================
+ Hits         200753   200826      +73     
+ Misses        63731    63590     -141     
- Partials      16642    16710      +68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

peternied · 2024-02-15T16:13:45Z

Test failures:

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java

Signed-off-by: Peter Nied <petern@amazon.com>

github-actions · 2024-02-15T20:34:10Z

❌ Gradle check result for 0dd44f7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java

server/src/test/java/org/opensearch/index/store/RemoteSegmentStoreDirectoryTests.java

github-actions · 2024-02-15T20:59:37Z

❌ Gradle check result for d77f812: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…eted Signed-off-by: Peter Nied <petern@amazon.com>

Signed-off-by: Peter Nied <petern@amazon.com>

github-actions · 2024-02-15T21:32:07Z

❌ Gradle check result for fc600ac: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Peter Nied <petern@amazon.com>

github-actions · 2024-02-15T22:20:35Z

❌ Gradle check result for dfcfe00: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

peternied · 2024-02-15T22:24:03Z

Test failure:

[BUG] org.opensearch.indices.IndicesRequestCacheIT.testCacheWithInvalidation is flaky #12308

github-actions · 2024-02-15T22:36:20Z

❌ Gradle check result for 673e4ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

opensearch-trigger-bot · 2024-02-16T02:15:06Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12328-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 006ba0e6068d18d5523f8975de7c4e1e5e797490
# Push it to GitHub
git push --set-upstream origin backport/backport-12328-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12328-to-2.x.

…gging is enabled (opensearch-project#12328) Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit 006ba0e)

…gging is enabled (#12328) (#12347)

opensearch-project#12328) Signed-off-by: Peter Nied <petern@amazon.com>

opensearch-project#12328) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled

4936736

Signed-off-by: Peter Nied <petern@amazon.com>

Add changelog entry

8c39071

Signed-off-by: Peter Nied <petern@amazon.com>

peternied added the backport 2.x Backport to 2.x branch label Feb 15, 2024

peternied mentioned this pull request Feb 15, 2024

Projected Views #11957

Merged

8 tasks

andrross reviewed Feb 15, 2024

View reviewed changes

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java Show resolved Hide resolved

Add test to validate debug log statement doesn't have errors

0dd44f7

Signed-off-by: Peter Nied <petern@amazon.com>

andrross reviewed Feb 15, 2024

View reviewed changes

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java Show resolved Hide resolved

server/src/test/java/org/opensearch/index/store/RemoteSegmentStoreDirectoryTests.java Show resolved Hide resolved

Dial back the level of detail validated for the segments that are del…

fc600ac

…eted Signed-off-by: Peter Nied <petern@amazon.com>

peternied force-pushed the RemoteSegmentStoreDirectory branch from d77f812 to fc600ac Compare February 15, 2024 21:06

Fix javadoc reference

dfcfe00

Signed-off-by: Peter Nied <petern@amazon.com>

Make the code annotation a single line in the javadoc

673e4ab

Signed-off-by: Peter Nied <petern@amazon.com>

andrross approved these changes Feb 15, 2024

View reviewed changes

peternied merged commit 006ba0e into opensearch-project:main Feb 16, 2024
27 of 28 checks passed

peternied deleted the RemoteSegmentStoreDirectory branch February 16, 2024 02:14

opensearch-trigger-bot bot added the backport-failed label Feb 16, 2024

peternied mentioned this pull request Feb 16, 2024

[Backport 2.x] Fix error in RemoteSegmentStoreDirectory when debug logging is enabled (#12328) #12347

Merged

8 tasks

peternied added a commit that referenced this pull request Feb 16, 2024

[Backport 2.x] Fix error in RemoteSegmentStoreDirectory when debug lo…

b7f8278

…gging is enabled (#12328) (#12347)

peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled (

d260214

opensearch-project#12328) Signed-off-by: Peter Nied <petern@amazon.com>

rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled (

a296cc8

opensearch-project#12328) Signed-off-by: Peter Nied <petern@amazon.com>

BrewTestBot mentioned this pull request Apr 3, 2024

opensearch 2.13.0 Homebrew/homebrew-core#167852

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled #12328

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled #12328

peternied commented Feb 15, 2024

peternied commented Feb 15, 2024

github-actions bot commented Feb 15, 2024 •

edited

Loading

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

codecov bot commented Feb 15, 2024 •

edited

Loading

peternied commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

peternied commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

opensearch-trigger-bot bot commented Feb 16, 2024

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled #12328

Fix error in RemoteSegmentStoreDirectory when debug logging is enabled #12328

Conversation

peternied commented Feb 15, 2024

Description

Related Issues

Check List

peternied commented Feb 15, 2024

github-actions bot commented Feb 15, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

codecov bot commented Feb 15, 2024 • edited Loading

Codecov Report

peternied commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

peternied commented Feb 15, 2024

github-actions bot commented Feb 15, 2024

opensearch-trigger-bot bot commented Feb 16, 2024

github-actions bot commented Feb 15, 2024 •

edited

Loading

codecov bot commented Feb 15, 2024 •

edited

Loading