Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TRIAGING instructions for closed issues #12382

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Feb 20, 2024

Description

During triage, some issues are closed due to insufficient information or other reasons.

The current TRIAGING document instructs Issue submitters to re-open a closed issue after addressing problems. However, only project committers have the permission to re-open a closed issue.

This PR updates the "canned response" to reflect this reality.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis
Copy link
Member Author

I can't figure out how to get the description checker action to pass. @peternied please merge peternied/check-pull-request-description-checklist#1 to make my life easier.

The documentation on the action could be more helpful in telling me how to handle indented bullets as well.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 2c87906

Incompatible components

Incompatible components: [https://github.com/opensearch-project/custom-codecs.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 2c87906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update, looks good to me

Copy link
Contributor

❌ Gradle check result for 2c87906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2c87906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2c87906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied
Copy link
Member

@dbwiddis When you get a chance please report all the test failures, gradle check is on its 5x try - this is kinda of ridiculous.

Copy link
Contributor

❌ Gradle check result for 2c87906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2c87906: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 2c87906: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b19e427) 71.34% compared to head (2c87906) 71.51%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12382      +/-   ##
============================================
+ Coverage     71.34%   71.51%   +0.17%     
- Complexity    59771    59858      +87     
============================================
  Files          4960     4960              
  Lines        281164   281166       +2     
  Branches      40862    40861       -1     
============================================
+ Hits         200590   201074     +484     
+ Misses        63872    63420     -452     
+ Partials      16702    16672      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit b0687eb into opensearch-project:main Feb 20, 2024
96 of 125 checks passed
@peternied
Copy link
Member

@dbwiddis I've followed all the failures, and created [1] to follow up.

Flaky test round up

Batch 1

Batch 2

Batch 3

Batch 4

Batch 5

Batch 6

Batch 7

peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
)

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

4 participants