-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TRIAGING instructions for closed issues #12382
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
I can't figure out how to get the description checker action to pass. @peternied please merge peternied/check-pull-request-description-checklist#1 to make my life easier. The documentation on the action could be more helpful in telling me how to handle indented bullets as well. |
Compatibility status:Checks if related components are compatible with change 2c87906 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/custom-codecs.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 2c87906: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update, looks good to me
❌ Gradle check result for 2c87906: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2c87906: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2c87906: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@dbwiddis When you get a chance please report all the test failures, gradle check is on its 5x try - this is kinda of ridiculous. |
❌ Gradle check result for 2c87906: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2c87906: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 2c87906: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12382 +/- ##
============================================
+ Coverage 71.34% 71.51% +0.17%
- Complexity 59771 59858 +87
============================================
Files 4960 4960
Lines 281164 281166 +2
Branches 40862 40861 -1
============================================
+ Hits 200590 201074 +484
+ Misses 63872 63420 -452
+ Partials 16702 16672 -30 ☔ View full report in Codecov by Sentry. |
Description
During triage, some issues are closed due to insufficient information or other reasons.
The current TRIAGING document instructs Issue submitters to re-open a closed issue after addressing problems. However, only project committers have the permission to re-open a closed issue.
This PR updates the "canned response" to reflect this reality.
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.