Integrate with CPU admission controller for cluster-manager Read API's. #12496

rajiv-kv · 2024-02-29T14:10:27Z

Description

Read actions of ClusterManager are integrated with admission control at transport layer. These transport actions are used by Admin API's to retrive information such as stats and metadata from cluster-state.
Sub-classes of TransportClusterManagerNodeReadAction that already have Circuit breaker limit enforced today have been additionally enforced with admission control. Action Type CLUSTER_INFO is introduced to configure admission thresholds & options for the Admin API's.

Related Issues

Resolves #7520

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-02-29T14:32:59Z

Compatibility status:

Checks if related components are compatible with change d9e42b5

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

github-actions · 2024-02-29T14:38:57Z

❌ Gradle check result for 68968cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shwetathareja

Thanks @rajiv-kv. On high level this looks good. Left few comments/ clarifications.

...java/org/opensearch/action/support/clustermanager/TransportClusterManagerNodeReadAction.java

...ain/java/org/opensearch/action/support/clustermanager/TransportClusterManagerNodeAction.java

...a/org/opensearch/ratelimitting/admissioncontrol/controllers/CpuBasedAdmissionController.java

server/src/main/java/org/opensearch/action/support/HandledTransportAction.java

.../opensearch/ratelimitting/admissioncontrol/settings/CpuBasedAdmissionControllerSettings.java

...java/org/opensearch/action/support/clustermanager/TransportClusterManagerNodeReadAction.java

server/src/main/java/org/opensearch/action/support/HandledTransportAction.java

github-actions · 2024-03-13T09:48:44Z

❌ Gradle check result for 8f3a5ea: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-03-20T16:04:11Z

❌ Gradle check result for 40fb58c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

shwetathareja · 2024-03-20T16:45:00Z

@rajiv-kv : Below test failed again.

[org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlEnforced](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlEnforced/)
    [org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlMonitorOnBreach](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlMonitorOnBreach/)
    [org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlResponseStatus](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlResponseStatus/)
    [org.opensearch.ratelimitting.admissioncontrol.AdmissionForClusterManagerIT.testAdmissionControlDisabledOnBreach](https://build.ci.opensearch.org/job/gradle-check/35460/testReport/junit/org.opensearch.ratelimitting.admissioncontrol/AdmissionForClusterManagerIT/testAdmissionControlDisabledOnBreach/)

github-actions · 2024-03-20T16:49:41Z

✅ Gradle check result for b6f885a: SUCCESS

github-actions · 2024-03-20T17:43:07Z

❌ Gradle check result for f55fe37: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

rajiv-kv · 2024-03-20T18:21:02Z

❌ Gradle check result for f55fe37: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky Test Issue

The admission control is enforced at the transport layer. Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

github-actions · 2024-03-21T08:56:58Z

✅ Gradle check result for d9e42b5: SUCCESS

opensearch-trigger-bot · 2024-03-21T10:45:23Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12496-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2069bd805804dd93bd69695a4c6521cc6f2b9bb6
# Push it to GitHub
git push --set-upstream origin backport/backport-12496-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12496-to-2.x.

…s. (opensearch-project#12496) * Integrate with CPU admission controller for cluster-manager Read API's. The admission control is enforced at the transport layer. Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

…s. (#12496) (#12829) * Integrate with CPU admission controller for cluster-manager Read API's. The admission control is enforced at the transport layer. Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

…s. (#12496) (#12832) * Integrate with CPU admission controller for cluster-manager Read API's. The admission control is enforced at the transport layer. Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

…s. (opensearch-project#12496) * Integrate with CPU admission controller for cluster-manager Read API's. The admission control is enforced at the transport layer. Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

github-actions bot added discuss Issues intended to help drive brainstorming and decision making distributed framework enhancement Enhancement or improvement to existing feature or request idea Things we're kicking around. RFC Issues requesting major changes labels Feb 29, 2024

shwetathareja reviewed Mar 7, 2024

View reviewed changes

ajaymovva suggested changes Mar 10, 2024

View reviewed changes

rajiv-kv force-pushed the admission-cpu branch from 8f3a5ea to 78b5ec1 Compare March 13, 2024 12:05

rajiv-kv marked this pull request as ready for review March 13, 2024 12:17

rajiv-kv requested review from peternied, abbashus, adnapibar, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, owaiskazi19, reta, Rishikesh1159 and ryanbogan as code owners March 13, 2024 12:17

rajiv-kv force-pushed the admission-cpu branch from b6f885a to f55fe37 Compare March 20, 2024 16:19

ajaymovva approved these changes Mar 20, 2024

View reviewed changes

shwetathareja approved these changes Mar 20, 2024

View reviewed changes

rajiv-kv added 5 commits March 21, 2024 13:27

Integrate with CPU admission controller for cluster-manager Read API's.

8fc8870

The admission control is enforced at the transport layer. Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

fixed the PR comments and added Settings test

a349fd8

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

fixed the PR comments and added Settings test

f751461

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

testcase to verify 429 response

e3b7570

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

updated changelog

d9e42b5

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>

rajiv-kv force-pushed the admission-cpu branch from f55fe37 to d9e42b5 Compare March 21, 2024 08:08

shwetathareja self-requested a review March 21, 2024 09:12

shwetathareja approved these changes Mar 21, 2024

View reviewed changes

shwetathareja merged commit 2069bd8 into opensearch-project:main Mar 21, 2024
33 checks passed

shwetathareja added the backport 2.x Backport to 2.x branch label Mar 21, 2024

opensearch-trigger-bot bot added the backport-failed label Mar 21, 2024

rajiv-kv mentioned this pull request Mar 21, 2024

Integrate with CPU admission controller for cluster-manager Read API'… #12829

Merged

8 tasks

rajiv-kv mentioned this pull request Mar 21, 2024

Integrate with CPU admission controller for cluster-manager Read API'… #12832

Merged

8 tasks

ajaymovva mentioned this pull request Mar 27, 2024

[META] Admission Controller Framework #9504

Open

14 tasks

BrewTestBot mentioned this pull request Apr 3, 2024

opensearch 2.13.0 Homebrew/homebrew-core#167852

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate with CPU admission controller for cluster-manager Read API's. #12496

Integrate with CPU admission controller for cluster-manager Read API's. #12496

rajiv-kv commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024

shwetathareja left a comment

github-actions bot commented Mar 13, 2024

github-actions bot commented Mar 20, 2024

shwetathareja commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

rajiv-kv commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 21, 2024

opensearch-trigger-bot bot commented Mar 21, 2024

Integrate with CPU admission controller for cluster-manager Read API's. #12496

Integrate with CPU admission controller for cluster-manager Read API's. #12496

Conversation

rajiv-kv commented Feb 29, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Feb 29, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Feb 29, 2024

shwetathareja left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 13, 2024

github-actions bot commented Mar 20, 2024

shwetathareja commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

rajiv-kv commented Mar 20, 2024 • edited Loading

github-actions bot commented Mar 21, 2024

opensearch-trigger-bot bot commented Mar 21, 2024

rajiv-kv commented Feb 29, 2024 •

edited

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

rajiv-kv commented Mar 20, 2024 •

edited

Loading