Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with float field terms query #12499

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented Feb 29, 2024

Description

Adds a failing integ test for terms query on a float field. This change fixes the use of FloatField back to FloatPoint. This was an accidental change that went in as part of #11209.

Related Issues

Resolves #12432

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Compatibility status:

Checks if related components are compatible with change cc173b1

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 2ea445d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Copy link
Contributor

❌ Gradle check result for 5c58e75: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b0d6fa5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f984b23: SUCCESS

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.40%. Comparing base (7921175) to head (cc173b1).
Report is 1 commits behind head on main.

Files Patch % Lines
...org/opensearch/index/mapper/NumberFieldMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12499      +/-   ##
============================================
+ Coverage     71.37%   71.40%   +0.02%     
- Complexity    59891    59914      +23     
============================================
  Files          4972     4972              
  Lines        281783   281797      +14     
  Branches      40910    40913       +3     
============================================
+ Hits         201136   201224      +88     
+ Misses        63977    63887      -90     
- Partials      16670    16686      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for cc173b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 1, 2024

✅ Gradle check result for cc173b1: SUCCESS

@reta reta merged commit 8a22f28 into opensearch-project:main Mar 8, 2024
42 of 48 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Mar 8, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12499-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8a22f284a19e986d7e2732762554e6e2fedbd25c
# Push it to GitHub
git push --set-upstream origin backport/backport-12499-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12499-to-2.x.

@reta
Copy link
Collaborator

reta commented Mar 8, 2024

@harshavamsi could you please backport to 2.x manually? thank you

harshavamsi added a commit to harshavamsi/OpenSearch that referenced this pull request Mar 8, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 8a22f28)
harshavamsi added a commit to harshavamsi/OpenSearch that referenced this pull request Mar 8, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 8a22f28)
harshavamsi added a commit to harshavamsi/OpenSearch that referenced this pull request Mar 8, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 8a22f28)
reta pushed a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit 8a22f28)
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 14, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Constant score query fails to execute against a float field with "doc_values": false
5 participants