Removing unused fetch sub phase processor initialization during fetch… #12503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… phase execution Signed-off-by: Ankit Jain <akjain@amazon.com>
jainankitk
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kartg,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
Compatibility status:Checks if related components are compatible with change 2bd910e Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security-analytics.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
|
❌ Gradle check result for a742967: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Mar 13, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12503-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da5b2053864f24dcb3b8c555a9fd19e0d91a14e6
# Push it to GitHub
git push --set-upstream origin backport/backport-12503-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
@jainankitk could you please backport manually to |
jainankitk
added a commit
to jainankitk/OpenSearch
that referenced
this pull request
Mar 14, 2024
opensearch-project#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <akjain@amazon.com> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing smoke test failures Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com> (cherry picked from commit da5b205)
andrross
pushed a commit
that referenced
this pull request
Mar 14, 2024
…on during fetch… (#12654) * Removing unused fetch sub phase processor initialization during fetch… (#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <akjain@amazon.com> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing smoke test failures Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com> (cherry picked from commit da5b205) * Removing unintended CHANGELOG issue Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com>
rayshrey
pushed a commit
to rayshrey/OpenSearch
that referenced
this pull request
Mar 18, 2024
opensearch-project#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <akjain@amazon.com> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing smoke test failures Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
opensearch-project#12503) * Removing unused fetch sub phase processor initialization during fetch phase execution Signed-off-by: Ankit Jain <akjain@amazon.com> * Updating CHANGELOG.md with the bug fix Signed-off-by: Ankit Jain <akjain@amazon.com> * Fixing smoke test failures Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments Signed-off-by: Ankit Jain <akjain@amazon.com> * Addressing review comments around boolean check convention Signed-off-by: Ankit Jain <akjain@amazon.com> --------- Signed-off-by: Ankit Jain <akjain@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
May 1, 2024
…ng fetch… (opensearch-project#12503)" This reverts commit da5b205.
Merged
8 tasks
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
May 1, 2024
…ng fetch… (opensearch-project#12503)" This reverts commit da5b205. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
7 tasks
reta
added a commit
that referenced
this pull request
May 2, 2024
…tialization during fetch… (#12503)" (#13492) * Revert "Removing unused fetch sub phase processor initialization during fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update 400_inner_hits.yml Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
reta
added a commit
that referenced
this pull request
May 2, 2024
…ialization during fetch… (#12503)" (#13491) * Revert "Removing unused fetch sub phase processor initialization during fetch… (#12503)" (#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 5133e5f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Update 400_inner_hits.yml Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
finnegancarroll
pushed a commit
to finnegancarroll/OpenSearch
that referenced
this pull request
May 10, 2024
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
May 17, 2024
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… phase execution
Description
Prevent initialization of unused fetch sub phase processor initialization during fetch phase execution
Related Issues
Resolves #12502
Check List
[ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.