Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase suite timeout for HighlighterSearchIT #12512

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Increase suite timeout for HighlighterSearchIT #12512

merged 1 commit into from
Mar 2, 2024

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Mar 1, 2024 •
edited
Loading

Description

Increase suite timeout as parameterization has doubled the number of tests being run.

From the cases where the test does time out the non-concurrent search case is taking ~14 minutes, so bumping the timeout up to 35 to be safe.
Ref: #12119 (comment)

Related Issues

Resolves #12119

Check List

- [x] New functionality includes testing.

  • All tests pass
    - [x] New functionality has been documented.
    - [x] New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
    - [x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)!
    - [x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc labels Mar 1, 2024
@jed326 jed326 marked this pull request as ready for review March 1, 2024 21:32
@jed326
Copy link
Collaborator Author

jed326 commented Mar 1, 2024

@peternied @reta could you help review? Thanks!

@jed326 jed326 added the backport 2.x Backport to 2.x branch label Mar 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change ab0a04c

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

❌ Gradle check result for 094331e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326
Copy link
Collaborator Author

jed326 commented Mar 1, 2024

https://build.ci.opensearch.org/job/gradle-check/34314/

@reta
Copy link
Collaborator

reta commented Mar 1, 2024

@peternied @reta could you help review? Thanks!

@jed326 my apologies , I am on vacation till the end of next week

@jed326
Increase suite timeout for HighlighterSearchIT
ab0a04c 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326 jed326 mentioned this pull request Mar 1, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2024

✅ Gradle check result for ab0a04c: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (7921175) to head (ab0a04c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12512      +/-   ##
============================================
+ Coverage     71.37%   71.43%   +0.05%     
- Complexity    59891    59918      +27     
============================================
  Files          4972     4972              
  Lines        281783   281797      +14     
  Branches      40910    40913       +3     
============================================
+ Hits         201136   201297     +161     
+ Misses        63977    63791     -186     
- Partials      16670    16709      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 9814eb9 into opensearch-project:main Mar 2, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 2, 2024
@github-actions
Increase suite timeout for HighlighterSearchIT (#12512)
b785e0d 
Signed-off-by: Jay Deng <jayd0104@gmail.com>
(cherry picked from commit 9814eb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 2, 2024
Merged
kotwanikunal pushed a commit that referenced this pull request Mar 3, 2024
@opensearch-trigger-bot @github-actions
Increase suite timeout for HighlighterSearchIT (#12512) (#12516)
e5e8fda 
(cherry picked from commit 9814eb9)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ltaragi pushed a commit to ltaragi/OpenSearch that referenced this pull request Mar 4, 2024
@jed326 @ltaragi
Increase suite timeout for HighlighterSearchIT (opensearch-project#12512
273e20c 
)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
@jed326
Increase suite timeout for HighlighterSearchIT (opensearch-project#12512
b2daf1d 
)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 14, 2024
@jed326
Increase suite timeout for HighlighterSearchIT (opensearch-project#12512
f309375 
)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@jed326 @rayshrey
Increase suite timeout for HighlighterSearchIT (opensearch-project#12512
503cc08 
)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@jed326 @shiv0408
Increase suite timeout for HighlighterSearchIT (opensearch-project#12512
7a2487f 
)

Signed-off-by: Jay Deng <jayd0104@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied approved these changes

@kkmr kkmr kkmr approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.search.fetch.subphase.highlight.HighlighterSearchIT.testBoostingQueryTermVector is flaky
4 participants
@jed326 @reta @peternied @kkmr