Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up jackson version to 2.16.2 #12611

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

amkhar
Copy link
Contributor

@amkhar amkhar commented Mar 12, 2024

Description

Bump up jackson to 2.16.2

Check List

- [ ] New functionality includes testing.

  • All tests pass
    - [ ] New functionality has been documented.
    - [ ] New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Aman Khare <amkhar@amazon.com>
Copy link
Contributor

github-actions bot commented Mar 12, 2024

Compatibility status:

Checks if related components are compatible with change 20551de

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Signed-off-by: Aman Khare <amkhar@amazon.com>
Copy link
Contributor

✅ Gradle check result for 3ad4dad: SUCCESS

Copy link
Contributor

❕ Gradle check result for 20551de: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.34%. Comparing base (b15cb0c) to head (20551de).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12611      +/-   ##
============================================
- Coverage     71.42%   71.34%   -0.08%     
+ Complexity    59978    59930      -48     
============================================
  Files          4985     4985              
  Lines        282275   282334      +59     
  Branches      40946    40951       +5     
============================================
- Hits         201603   201444     -159     
- Misses        63999    64176     +177     
- Partials      16673    16714      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 69fc7dd into opensearch-project:main Mar 12, 2024
36 of 40 checks passed
@dblock dblock added the backport 2.x Backport to 2.x branch label Mar 12, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12611-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 69fc7dd5bf53c22bac9d4938b408cc56f7011c39
# Push it to GitHub
git push --set-upstream origin backport/backport-12611-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12611-to-2.x.

@dblock
Copy link
Member

dblock commented Mar 12, 2024

@amkhar please backport manually to 2.x if you believe it's needed

reta pushed a commit to reta/OpenSearch that referenced this pull request Mar 12, 2024
* Bump up jackson to 2.16.2

Signed-off-by: Aman Khare <amkhar@amazon.com>

* Add changelog entry

Signed-off-by: Aman Khare <amkhar@amazon.com>

---------

Signed-off-by: Aman Khare <amkhar@amazon.com>
Co-authored-by: Aman Khare <amkhar@amazon.com>
(cherry picked from commit 69fc7dd)
@reta
Copy link
Collaborator

reta commented Mar 12, 2024

@amkhar please backport manually to 2.x if you believe it's needed

I just made it (was manually backporting other pull requests)

reta pushed a commit to reta/OpenSearch that referenced this pull request Mar 12, 2024
* Bump up jackson to 2.16.2

Signed-off-by: Aman Khare <amkhar@amazon.com>

* Add changelog entry

Signed-off-by: Aman Khare <amkhar@amazon.com>

---------

Signed-off-by: Aman Khare <amkhar@amazon.com>
Co-authored-by: Aman Khare <amkhar@amazon.com>
(cherry picked from commit 69fc7dd)
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
kotwanikunal pushed a commit that referenced this pull request Mar 12, 2024
* Bump up jackson to 2.16.2



* Add changelog entry



---------



(cherry picked from commit 69fc7dd)

Signed-off-by: Aman Khare <amkhar@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Aman Khare <85096200+amkhar@users.noreply.github.com>
Co-authored-by: Aman Khare <amkhar@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
* Bump up jackson to 2.16.2

Signed-off-by: Aman Khare <amkhar@amazon.com>

* Add changelog entry

Signed-off-by: Aman Khare <amkhar@amazon.com>

---------

Signed-off-by: Aman Khare <amkhar@amazon.com>
Co-authored-by: Aman Khare <amkhar@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Bump up jackson to 2.16.2

Signed-off-by: Aman Khare <amkhar@amazon.com>

* Add changelog entry

Signed-off-by: Aman Khare <amkhar@amazon.com>

---------

Signed-off-by: Aman Khare <amkhar@amazon.com>
Co-authored-by: Aman Khare <amkhar@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants