-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize remote state stale file deletion #13131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiv0408
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
April 9, 2024 06:38
github-actions
bot
added
Cluster Manager
enhancement
Enhancement or improvement to existing feature or request
labels
Apr 9, 2024
shiv0408
commented
Apr 9, 2024
.../src/internalClusterTest/java/org/opensearch/gateway/remote/RemoteClusterStateServiceIT.java
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13131-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b9befaa12524744ffe71d3f12699cb27cb8fca5e
# Push it to GitHub
git push --set-upstream origin backport/backport-13131-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
9 tasks
andrross
pushed a commit
that referenced
this pull request
Jun 4, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jun 5, 2024
…#13131)" (opensearch-project#13969) This reverts commit b9befaa. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
9 tasks
gaobinlong
pushed a commit
to gaobinlong/OpenSearch
that referenced
this pull request
Jun 5, 2024
…#13131)" (opensearch-project#13969) This reverts commit b9befaa. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
LantaoJin
pushed a commit
to LantaoJin/OpenSearch
that referenced
this pull request
Jun 6, 2024
…#13131)" (opensearch-project#13969) This reverts commit b9befaa. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Added UT Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Refactored into a clean up manager file Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add UT Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Modify the Integ test Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Address PR comment Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add changelog Signed-off-by: Shivansh Arora <hishiv@amazon.com> * apply spotless Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Made minor requested changes Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Fix default time interval Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Clean up global metadata attribute objects from remote Signed-off-by: Shivansh Arora <hishiv@amazon.com> * fix build Signed-off-by: Shivansh Arora <hishiv@amazon.com> * apply spotless Signed-off-by: Shivansh Arora <hishiv@amazon.com> * remove MockAsyncUploadFSRepo to avoid flakiness Signed-off-by: Shivansh Arora <hishiv@amazon.com> * apply spotless Signed-off-by: Shivansh Arora <hishiv@amazon.com> --------- Signed-off-by: Shivansh Arora <hishiv@amazon.com>
parv0201
pushed a commit
to parv0201/OpenSearch
that referenced
this pull request
Jun 10, 2024
…#13131)" (opensearch-project#13969) This reverts commit b9befaa. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
3 tasks
This was referenced Jun 27, 2024
Open
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
* Optimize remote state stale file deletion Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Added UT Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Refactored into a clean up manager file Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add UT Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Modify the Integ test Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Address PR comment Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add changelog Signed-off-by: Shivansh Arora <hishiv@amazon.com> * apply spotless Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Made minor requested changes Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Fix default time interval Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Clean up global metadata attribute objects from remote Signed-off-by: Shivansh Arora <hishiv@amazon.com> * fix build Signed-off-by: Shivansh Arora <hishiv@amazon.com> * apply spotless Signed-off-by: Shivansh Arora <hishiv@amazon.com> * remove MockAsyncUploadFSRepo to avoid flakiness Signed-off-by: Shivansh Arora <hishiv@amazon.com> * apply spotless Signed-off-by: Shivansh Arora <hishiv@amazon.com> --------- Signed-off-by: Shivansh Arora <hishiv@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…#13131)" (opensearch-project#13969) This reverts commit b9befaa. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
PRs or issues specific to backporting features or enhancments
backport 2.x
Backport to 2.x branch
backport-failed
bug
Something isn't working
Cluster Manager
enhancement
Enhancement or improvement to existing feature or request
flaky-test
Random test failure that succeeds on second run
Storage:Remote
v2.15.0
Issues and PRs related to version 2.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created an async task
AsyncStaleFileDeletion
which is initialized on only master eligible nodes. Once the task in initialized inRemoteClusterStateService
start()
, it schedules a clean up after specified interval which is added as a dynamic settingcluster.remote_store.state.cleanup_interval
with 5 min default.Clean up is also proceeded with if we have more than 10 successful states updates since last clean up. After trying clean up once, we schedule the task again after the set interval.
Related Issues
Resolves #12889
Resolves #12798 that test case is getting removed in this PR
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.