Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tiered Caching] Stats rework (3/4): Exposing new cache stats API #13237

Merged
merged 23 commits into from
Apr 29, 2024

rerun

5d76f0d
Select commit
Loading
Failed to load commit list.
Merged

[Tiered Caching] Stats rework (3/4): Exposing new cache stats API #13237

rerun
5d76f0d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2024 in 0s

71.38% (target 70.00%)

View this Pull Request on Codecov

71.38% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 77.30263% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 71.38%. Comparing base (b15cb0c) to head (5d76f0d).
Report is 230 commits behind head on main.

Files Patch % Lines
...est/action/admin/cluster/RestNodesStatsAction.java 0.00% 15 Missing and 1 partial ⚠️
...pensearch/common/cache/service/NodeCacheStats.java 48.00% 10 Missing and 3 partials ⚠️
...h/action/admin/indices/stats/CommonStatsFlags.java 63.15% 5 Missing and 2 partials ⚠️
.../common/cache/stats/ImmutableCacheStatsHolder.java 94.77% 3 Missing and 4 partials ⚠️
...in/java/org/opensearch/common/cache/CacheType.java 57.14% 6 Missing ⚠️
...rch/action/admin/cluster/node/stats/NodeStats.java 44.44% 3 Missing and 2 partials ⚠️
.../opensearch/common/cache/service/CacheService.java 0.00% 5 Missing ⚠️
.../opensearch/core/common/io/stream/StreamInput.java 63.63% 2 Missing and 2 partials ⚠️
...src/main/java/org/opensearch/node/NodeService.java 33.33% 0 Missing and 2 partials ⚠️
.../opensearch/cache/store/disk/EhcacheDiskCache.java 83.33% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13237      +/-   ##
============================================
- Coverage     71.42%   71.38%   -0.04%     
- Complexity    59978    60826     +848     
============================================
  Files          4985     5048      +63     
  Lines        282275   286330    +4055     
  Branches      40946    41469     +523     
============================================
+ Hits         201603   204391    +2788     
- Misses        63999    65035    +1036     
- Partials      16673    16904     +231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.