-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Routing Table] Initial commit for RemoteRoutingTableService setup #13304
[Remote Routing Table] Initial commit for RemoteRoutingTableService setup #13304
Conversation
❌ Gradle check result for 725b2bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directionally looks fine from keeping a separate repo and gating the feature behind a feature flag. We would need some integration and basic tests before we can consider merging this change in
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
725b2bd
to
d5a17ed
Compare
❌ Gradle check result for d5a17ed: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
server/src/main/java/org/opensearch/node/remotestore/RemoteStoreNodeAttribute.java
Show resolved
Hide resolved
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13304-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51214092ca532b557b6775ff8620025a51f92fcc
# Push it to GitHub
git push --set-upstream origin backport/backport-13304-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com> (cherry picked from commit 5121409)
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
…ensearch-project#13304) (opensearch-project#14026) * [Remote Routing Table] Introducing RemoteRoutingTableService (opensearch-project#13304) Signed-off-by: Himshikha Gupta <himshikh@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
…etup (opensearch-project#13304) * Initial commit for RemoteRoutingTableService setup Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Description
This change is for setting up base service for remote routing table operations.
Related Issues
Resolves (#13049)
Check List
[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.