Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/QueryGroup Add CRUD APIs in plugin #13315
Feature/QueryGroup Add CRUD APIs in plugin #13315
Changes from all commits
8217a77
019c5aa
028b0ce
ace034c
b722313
ea727b9
a41f10b
cd09285
14e9d7b
df8035b
5d57745
7050596
4182e07
43dec36
fd9ecee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 23 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupAction.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupAction.java#L23
Check warning on line 35 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupAction.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupAction.java#L34-L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update the schema to most recent one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This schema is the most recent one. The schema in QueryGroup (pasted below) is how we want to store the querygroup internally, it has id on the outside so users shouldn't use that schema when creating a querygroup.
Check warning on line 52 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L52
Check warning on line 88 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L87-L88
Check warning on line 139 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L139
Check warning on line 168 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L168
Check warning on line 186 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L186
Check warning on line 192 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L192
Check warning on line 202 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L202
Check warning on line 206 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L206
Check warning on line 214 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L210-L214
Check warning on line 217 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L217
Check warning on line 220 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L220
Check warning on line 223 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L223
Check warning on line 225 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L225
Check warning on line 227 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L227
Check warning on line 229 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L229
Check warning on line 233 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L233
Check warning on line 238 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L238
Check warning on line 254 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L253-L254
Check warning on line 269 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L268-L269
Check warning on line 284 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L283-L284
Check warning on line 296 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L296
Check warning on line 305 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L304-L305
Check warning on line 320 in plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java
Codecov / codecov/patch
plugins/query-group/src/main/java/org/opensearch/plugin/qg/CreateQueryGroupRequest.java#L319-L320