-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: The aggs result of NestedAggregator with sub NestedAggregator may be not accurately #13324
Conversation
❌ Gradle check result for 1087f86: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 849dad4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b710761: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...er/src/test/java/org/opensearch/search/aggregations/bucket/nested/NestedAggregatorTests.java
Outdated
Show resolved
Hide resolved
There was another CHANGELOG conflict, pushed a resolution |
❌ Gradle check result for 32e6937: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Thanks @kkewwei! I promise we'll get this merged :) |
❌ Gradle check result for 32e6937: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…y be not accurately Signed-off-by: kkewwei <kkewwei@163.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13324-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f5dbbb04b96bb8866255e4f967241db8bed16141
# Push it to GitHub
git push --set-upstream origin backport/backport-13324-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Signed-off-by: kkewwei <kkewwei@163.com> (cherry picked from commit f5dbbb0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…arch-project#13324) Signed-off-by: kkewwei <kkewwei@163.com>
…arch-project#13324) (opensearch-project#14496) (cherry picked from commit f5dbbb0) Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
…arch-project#13324) Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei kkewwei@163.com
Description
The aggs result of NestedAggregator with sub NestedAggregator may be not accurately, it depends on the face that the parentDocId > childDocId in search, but it may be wrong.
Related Issues
Resolves #13303
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.