Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13367

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

astute-decipher
Copy link
Contributor

@astute-decipher astute-decipher commented Apr 24, 2024

Description

Adding IT to validate that Remote Index Path file gets created after migration completes. For that we also need to ensure that RemoteClusterState is enabled, hence enabling the same in ITs.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ng migration direction to remote-store

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Copy link
Contributor

❌ Gradle check result for d247279: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 1072a87: SUCCESS

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (b15cb0c) to head (1752fa6).
Report is 332 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13367      +/-   ##
============================================
+ Coverage     71.42%   71.67%   +0.25%     
- Complexity    59978    61306    +1328     
============================================
  Files          4985     5064      +79     
  Lines        282275   288088    +5813     
  Branches      40946    41715     +769     
============================================
+ Hits         201603   206488    +4885     
- Misses        63999    64559     +560     
- Partials      16673    17041     +368     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 9, 2024

❌ Gradle check result for 4eedad9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 9, 2024

❌ Gradle check result for af14481: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Copy link
Contributor

❌ Gradle check result for d5bd0ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Shubh Sahu added 2 commits May 13, 2024 11:53
Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
@astute-decipher astute-decipher changed the title [Remote Store] Adding validation for remote-cluster-state to be enabled before putting migration direction to remote-store [Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. May 13, 2024
Copy link
Contributor

❌ Gradle check result for 743aaef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Copy link
Contributor

❌ Gradle check result for c47dc57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1752fa6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1752fa6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 3, 2024

❕ Gradle check result for 1752fa6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gbbafna gbbafna merged commit 896b127 into opensearch-project:main Jun 3, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 3, 2024
… after migration for each index. (#13367)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
(cherry picked from commit 896b127)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Jun 5, 2024
… after migration for each index. (#13367) (#13930)

(cherry picked from commit 896b127)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
… after migration for each index. (opensearch-project#13367)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
… after migration for each index. (opensearch-project#13367) (opensearch-project#13930)

(cherry picked from commit 896b127)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
… after migration for each index. (opensearch-project#13367)

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants