[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13367

astute-decipher · 2024-04-24T10:39:29Z

Description

Adding IT to validate that Remote Index Path file gets created after migration completes. For that we also need to ensure that RemoteClusterState is enabled, hence enabling the same in ITs.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[] ~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ng migration direction to remote-store Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

github-actions · 2024-04-24T11:35:28Z

❌ Gradle check result for d247279: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-04-24T11:43:32Z

✅ Gradle check result for 1072a87: SUCCESS

codecov · 2024-04-24T11:44:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.67%. Comparing base (b15cb0c) to head (1752fa6).
Report is 332 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13367      +/-   ##
============================================
+ Coverage     71.42%   71.67%   +0.25%     
- Complexity    59978    61306    +1328     
============================================
  Files          4985     5064      +79     
  Lines        282275   288088    +5813     
  Branches      40946    41715     +769     
============================================
+ Hits         201603   206488    +4885     
- Misses        63999    64559     +560     
- Partials      16673    17041     +368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-05-09T06:52:15Z

❌ Gradle check result for 4eedad9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-05-09T07:08:24Z

❌ Gradle check result for af14481: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

github-actions · 2024-05-10T09:56:00Z

❌ Gradle check result for d5bd0ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… into serengity_personel

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

github-actions · 2024-05-13T07:36:22Z

❌ Gradle check result for 743aaef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

...nalClusterTest/java/org/opensearch/remotemigration/RemoteMigrationIndexMetadataUpdateIT.java

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

github-actions · 2024-05-14T06:29:10Z

❌ Gradle check result for c47dc57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… into serengity_personel

github-actions · 2024-05-30T03:22:18Z

❌ Gradle check result for 1752fa6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-05-31T09:57:10Z

❌ Gradle check result for 1752fa6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-06-03T10:02:00Z

❕ Gradle check result for 1752fa6: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

… after migration for each index. (#13367) Signed-off-by: Shubh Sahu <shubhvs@amazon.com> (cherry picked from commit 896b127) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… after migration for each index. (#13367) (#13930) (cherry picked from commit 896b127) Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

… after migration for each index. (opensearch-project#13367) Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

… after migration for each index. (opensearch-project#13367) (opensearch-project#13930) (cherry picked from commit 896b127) Signed-off-by: Shubh Sahu <shubhvs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>

… after migration for each index. (opensearch-project#13367) Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

Adding validation for remote-cluster-state to be enabled before putti…

1072a87

…ng migration direction to remote-store Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

astute-decipher force-pushed the serengity_personel branch from d247279 to 1072a87 Compare April 24, 2024 10:50

astute-decipher self-assigned this Apr 24, 2024

astute-decipher added skip-changelog backport 2.x Backport to 2.x branch labels Apr 24, 2024

astute-decipher marked this pull request as ready for review April 24, 2024 12:00

astute-decipher requested review from anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami, tlfeng and VachaShah as code owners April 24, 2024 12:00

Adding IT to validate if remote index path file exists

d5bd0ca

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

Shubh Sahu added 2 commits May 13, 2024 11:53

Merge branch 'main' of https://github.com/opensearch-project/OpenSearch…

8d9d4ce

… into serengity_personel

Removing remote cluster state assertion

743aaef

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

astute-decipher changed the title ~~[Remote Store] Adding validation for remote-cluster-state to be enabled before putting migration direction to remote-store~~ [Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. May 13, 2024

gbbafna reviewed May 13, 2024

View reviewed changes

Addressed comment on PR

c47dc57

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

Merge branch 'main' of https://github.com/opensearch-project/OpenSearch…

1752fa6

… into serengity_personel

gbbafna approved these changes May 31, 2024

View reviewed changes

gbbafna merged commit 896b127 into opensearch-project:main Jun 3, 2024
30 checks passed

opensearch-trigger-bot bot mentioned this pull request Jun 3, 2024

[Backport 2.x] [Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13930

Merged

parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created…

9946f61

… after migration for each index. (opensearch-project#13367) Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

This was referenced Jun 13, 2024

[AUTOCUT] Gradle Check Flaky Test Report for RemoteMigrationIndexMetadataUpdateIT #14295

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreStatsIT #14310

Open

[AUTOCUT] Gradle Check Flaky Test Report for ShardIndexingPressureSettingsIT #14331

Open

finnegancarroll mentioned this pull request Jun 14, 2024

Remove composeBuild fixture tasks when docker support not found #14357

Merged

3 tasks

prudhvigodithi mentioned this pull request Jun 18, 2024

[AUTOCUT] Gradle Check Flaky Test Report for IndicesRequestCacheIT prudhvigodithi/OpenSearch#27

Closed

This was referenced Jun 27, 2024

[AUTOCUT] Gradle Check Flaky Test Report for IndicesRequestCacheIT #14288

Open

[AUTOCUT] Gradle Check Flaky Test Report for S3BlobStoreRepositoryTests #14299

Open

wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created…

b108af3

… after migration for each index. (opensearch-project#13367) Signed-off-by: Shubh Sahu <shubhvs@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13367

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13367

astute-decipher commented Apr 24, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

codecov bot commented Apr 24, 2024 •

edited

Loading

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 10, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 14, 2024

github-actions bot commented May 30, 2024

github-actions bot commented May 31, 2024

github-actions bot commented Jun 3, 2024

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13367

[Remote Store] Adding ITs to ensure RemoteIndexPath file gets created after migration for each index. #13367

Conversation

astute-decipher commented Apr 24, 2024 • edited Loading

Description

Related Issues

Check List

github-actions bot commented Apr 24, 2024

github-actions bot commented Apr 24, 2024

codecov bot commented Apr 24, 2024 • edited Loading

Codecov Report

github-actions bot commented May 9, 2024

github-actions bot commented May 9, 2024

github-actions bot commented May 10, 2024

github-actions bot commented May 13, 2024

github-actions bot commented May 14, 2024

github-actions bot commented May 30, 2024

github-actions bot commented May 31, 2024

github-actions bot commented Jun 3, 2024

astute-decipher commented Apr 24, 2024 •

edited

Loading

codecov bot commented Apr 24, 2024 •

edited

Loading