[Backport 2.x] Fix flaky test CacheStatsAPIIndicesRequestCacheIT.testNullLevels() #13475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…13457) * Fix flaky test Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Initialize CommonStatsFlags with empty array for levels Signed-off-by: Peter Alfonsi <petealft@amazon.com> * Fixes tests using incorrect null levels Signed-off-by: Peter Alfonsi <petealft@amazon.com> * rerun Signed-off-by: Peter Alfonsi <petealft@amazon.com> --------- Signed-off-by: Peter Alfonsi <petealft@amazon.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> (cherry picked from commit 5d61ac2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
dblock
approved these changes
Apr 30, 2024
|
❌ Gradle check result for d818ddc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
^ New flaky test issue: #13476 |
|
I don't think I can rerun the gradle check as I don't yet have triage access to the repo, and the branch isn't in my fork. @dblock would you mind rerunning it? |
|
Reran the gradle check. |
|
❌ Gradle check result for d818ddc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
#13473 (flaky test) |
|
❕ Gradle check result for d818ddc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@dblock @VachaShah I think this is ready to merge. |
VachaShah
approved these changes
May 1, 2024
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
May 1, 2024
…pensearch-project#13457) (opensearch-project#13475) * Fix flaky test * Initialize CommonStatsFlags with empty array for levels * Fixes tests using incorrect null levels * rerun --------- (cherry picked from commit 5d61ac2) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> (cherry picked from commit 291f686)
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
May 1, 2024
…pensearch-project#13457) (opensearch-project#13475) * Fix flaky test * Initialize CommonStatsFlags with empty array for levels * Fixes tests using incorrect null levels * rerun --------- (cherry picked from commit 5d61ac2) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> (cherry picked from commit 291f686)
Merged
8 tasks
dblock
pushed a commit
that referenced
this pull request
May 1, 2024
…13457) (#13475) (#13485) * Fix flaky test * Initialize CommonStatsFlags with empty array for levels * Fixes tests using incorrect null levels * rerun --------- (cherry picked from commit 5d61ac2) Signed-off-by: Peter Alfonsi <petealft@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Peter Alfonsi <petealft@amazon.com> (cherry picked from commit 291f686) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5d61ac2 from #13457.