-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true' #13532
Conversation
❌ Gradle check result for edb0cf8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 330dc55: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…fault to 'true' Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
❌ Gradle check result for cfc8088: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@andrross mind taking a look please? thank you! |
❌ Gradle check result for cfc8088: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for cfc8088: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for cfc8088: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13532 +/- ##
============================================
+ Coverage 71.42% 71.54% +0.11%
- Complexity 59978 61092 +1114
============================================
Files 4985 5052 +67
Lines 282275 287124 +4849
Branches 40946 41602 +656
============================================
+ Hits 201603 205409 +3806
- Misses 63999 64741 +742
- Partials 16673 16974 +301 ☔ View full report in Codecov by Sentry. |
Thanks @reta! I'm wondering if we should backport this to earlier versions as well (I think this was first introduced in 2.11)? |
…fault to 'true' (opensearch-project#13532) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…fault to 'true' (opensearch-project#13532) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…fault to 'true' (opensearch-project#13532) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Description
DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true'
Related Issues
Closes #13411 (documentation update to follow shortly)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.