Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true' #13532

Merged
merged 1 commit into from
May 4, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented May 3, 2024

Description

DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to 'true'

Related Issues

Closes #13411 (documentation update to follow shortly)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0 labels May 3, 2024
@reta reta added backport 2.x Backport to 2.x branch backport 2.14 Backport to 2.14 branch labels May 3, 2024
Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for edb0cf8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for 330dc55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…fault to 'true'

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for cfc8088: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented May 3, 2024

❌ Gradle check result for cfc8088: FAILURE

#13473

@reta
Copy link
Collaborator Author

reta commented May 3, 2024

@andrross mind taking a look please? thank you!

Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for cfc8088: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 3, 2024

❌ Gradle check result for cfc8088: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented May 3, 2024

❌ Gradle check result for cfc8088: FAILURE

* What went wrong:
Execution failed for task ':plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestKeyStore'.
> process was found dead while waiting for ports files, node{:plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestKeyStore-0}

@reta
Copy link
Collaborator Author

reta commented May 3, 2024

❌ Gradle check result for cfc8088: FAILURE

#12685

Copy link
Contributor

github-actions bot commented May 4, 2024

❕ Gradle check result for cfc8088: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.testShardIndexingPressureEnforcedEnabledDisabledSetting
      1 org.opensearch.index.ShardIndexingPressureSettingsIT.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (b15cb0c) to head (cfc8088).
Report is 263 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13532      +/-   ##
============================================
+ Coverage     71.42%   71.54%   +0.11%     
- Complexity    59978    61092    +1114     
============================================
  Files          4985     5052      +67     
  Lines        282275   287124    +4849     
  Branches      40946    41602     +656     
============================================
+ Hits         201603   205409    +3806     
- Misses        63999    64741     +742     
- Partials      16673    16974     +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 9106713 into opensearch-project:main May 4, 2024
28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2024
…fault to 'true' (#13532)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 9106713)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 4, 2024
…fault to 'true' (#13532)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 9106713)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 4, 2024
…fault to 'true' (#13532) (#13538)

(cherry picked from commit 9106713)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 4, 2024
…fault to 'true' (#13532) (#13537)

(cherry picked from commit 9106713)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@jed326
Copy link
Collaborator

jed326 commented May 5, 2024

Thanks @reta! I'm wondering if we should backport this to earlier versions as well (I think this was first introduced in 2.11)?

@reta
Copy link
Collaborator Author

reta commented May 5, 2024

Thanks @reta! I'm wondering if we should backport this to earlier versions as well (I think this was first introduced in 2.11)?

Thanks @jed326, I think we are not planing to release any patches for previous versions

finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
…fault to 'true' (opensearch-project#13532)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…fault to 'true' (opensearch-project#13532)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…fault to 'true' (opensearch-project#13532)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.14 Backport to 2.14 branch bug Something isn't working Indexing Indexing, Bulk Indexing and anything related to indexing v2.14.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DATETIME_FORMATTER_CACHING_SETTING experimental feature should not default to true
3 participants