Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky #13658

Merged
merged 5 commits into from
May 16, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented May 14, 2024

Description

This PR fixes the flaky test org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric(), this bug is caused by a new metric type caches which was introduced in this PR: #13237, the caches type is handled separately when prepare the node stats request, so we should remove the caches type from the metrics set in the test method testIndexMetricsRequestWithoutIndicesMetric(), and add a new test case to make sure that the caches type can be covered by the unit tests.

Changelog is not needed, but backport is 2.x is needed.

Related Issues

#13504

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…s.testIndexMetricsRequestWithoutIndicesMetric is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

❌ Gradle check result for d645d43: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Copy link
Collaborator Author

❌ Gradle check result for d645d43: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known issue:#13600

Copy link
Contributor

❌ Gradle check result for f698d09: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f698d09: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 15c1632: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gaobinlong
Copy link
Collaborator Author

❌ Gradle check result for 15c1632: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known issue: #6542.

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

❌ Gradle check result for c71e3d3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 15, 2024

Needs #13673 :(

@reta
Copy link
Collaborator

reta commented May 15, 2024

@gaobinlong could you rebase please? thank you

Copy link
Contributor

❌ Gradle check result for f56b039: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 16, 2024

❌ Gradle check result for f56b039: FAILURE

#7791
#13711

Copy link
Contributor

❌ Gradle check result for f56b039: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 16, 2024

❌ Gradle check result for f56b039: FAILURE

java.lang.Exception: Test abandoned because suite timeout was reached.
	at __randomizedtesting.SeedInfo.seed([7618A989E9259E68]:0)

Copy link
Contributor

✅ Gradle check result for f56b039: SUCCESS

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.60%. Comparing base (b15cb0c) to head (f56b039).
Report is 287 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13658      +/-   ##
============================================
+ Coverage     71.42%   71.60%   +0.18%     
- Complexity    59978    61221    +1243     
============================================
  Files          4985     5059      +74     
  Lines        282275   287522    +5247     
  Branches      40946    41646     +700     
============================================
+ Hits         201603   205890    +4287     
- Misses        63999    64668     +669     
- Partials      16673    16964     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit f30e0e0 into opensearch-project:main May 16, 2024
28 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label May 16, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 16, 2024
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (#13658)

* Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Change test method name

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit f30e0e0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 16, 2024
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (#13658) (#13716)

* Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky



* Change test method name



---------


(cherry picked from commit f30e0e0)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (opensearch-project#13658)

* Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Change test method name

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (opensearch-project#13658)

* Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Change test method name

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants