-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky #13658
Conversation
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for d645d43: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known issue:#13600 |
❌ Gradle check result for f698d09: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/test/java/org/opensearch/rest/action/admin/cluster/RestNodesStatsActionTests.java
Show resolved
Hide resolved
❌ Gradle check result for f698d09: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 15c1632: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known issue: #6542. |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for c71e3d3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Needs #13673 :( |
@gaobinlong could you rebase please? thank you |
❌ Gradle check result for f56b039: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f56b039: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13658 +/- ##
============================================
+ Coverage 71.42% 71.60% +0.18%
- Complexity 59978 61221 +1243
============================================
Files 4985 5059 +74
Lines 282275 287522 +5247
Branches 40946 41646 +700
============================================
+ Hits 201603 205890 +4287
- Misses 63999 64668 +669
- Partials 16673 16964 +291 ☔ View full report in Codecov by Sentry. |
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (#13658) * Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Change test method name Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit f30e0e0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (#13658) (#13716) * Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky * Change test method name --------- (cherry picked from commit f30e0e0) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (opensearch-project#13658) * Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Change test method name Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…s.testIndexMetricsRequestWithoutIndicesMetric is flaky (opensearch-project#13658) * Fix org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Change test method name Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Description
This PR fixes the flaky test
org.opensearch.rest.action.admin.cluster.RestNodesStatsActionTests.testIndexMetricsRequestWithoutIndicesMetric()
, this bug is caused by a new metric typecaches
which was introduced in this PR: #13237, thecaches
type is handled separately when prepare the node stats request, so we should remove thecaches
type from the metrics set in the test methodtestIndexMetricsRequestWithoutIndicesMetric()
, and add a new test case to make sure that thecaches
type can be covered by the unit tests.Changelog is not needed, but backport is 2.x is needed.
Related Issues
#13504
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.