Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remote Store] Add segment transfer timeout dynamic setting (#13679) #13793

Merged

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented May 23, 2024

  • [Remote Store] Add segment transfer timeout dynamic setting

Signed-off-by: Varun Bansal bansvaru@amazon.com
(cherry picked from commit b3049fb)

Description

Backport of #13679

@linuxpi linuxpi marked this pull request as ready for review May 23, 2024 07:30
@linuxpi linuxpi self-assigned this May 23, 2024
@linuxpi linuxpi changed the title [Remote Store] Add segment transfer timeout dynamic setting (#13679) [Backport 2.x] [Remote Store] Add segment transfer timeout dynamic setting (#13679) May 23, 2024
Copy link
Contributor

❕ Gradle check result for 0c4cb0f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.36%. Comparing base (0dd892c) to head (f58cf99).
Report is 270 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/indices/RemoteStoreSettings.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13793      +/-   ##
============================================
+ Coverage     71.28%   71.36%   +0.08%     
- Complexity    60145    61412    +1267     
============================================
  Files          4957     5038      +81     
  Lines        282799   288391    +5592     
  Branches      41409    42134     +725     
============================================
+ Hits         201591   205816    +4225     
- Misses        64189    65255    +1066     
- Partials      17019    17320     +301     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 0ce505b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@linuxpi
Copy link
Collaborator Author

linuxpi commented May 23, 2024

Copy link
Contributor

❌ Gradle check result for 0ce505b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326
Copy link
Collaborator

jed326 commented May 23, 2024

Copy link
Contributor

❌ Gradle check result for 0ce505b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0ce505b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ch-project#13679)

* [Remote Store] Add segment transfer timeout dynamic setting

Signed-off-by: Varun Bansal <bansvaru@amazon.com>
(cherry picked from commit b3049fb)
@linuxpi linuxpi force-pushed the backport/backport-13679-to-2.x branch from 0ce505b to f58cf99 Compare May 24, 2024 06:06
Copy link
Contributor

❌ Gradle check result for f58cf99: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for f58cf99: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants