-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of RemoteWritableEntity for objects to uploaded to remote store #13834
Conversation
❌ Gradle check result for 6842837: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ee52329: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the PR needs to be refreshed based on the #13785
034395a
to
8a8622c
Compare
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13834 +/- ##
============================================
+ Coverage 71.42% 71.73% +0.31%
- Complexity 59978 61692 +1714
============================================
Files 4985 5089 +104
Lines 282275 289404 +7129
Branches 40946 41858 +912
============================================
+ Hits 201603 207603 +6000
- Misses 63999 64661 +662
- Partials 16673 17140 +467 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13834-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49282c111c593bb2b1ee76b50102c06fa1f2c627
# Push it to GitHub
git push --set-upstream origin backport/backport-13834-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
…ote store (opensearch-project#13834) (opensearch-project#14098) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Description
This change implements the interface created in the PR #13785. The implementation is done for the objects which need to be uploaded to remote store.
Related Issues
NA
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.