Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conflicting static method from Metadata.Custom interface #13869

Merged
merged 1 commit into from
May 30, 2024
Merged

Remove conflicting static method from Metadata.Custom interface #13869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions server/src/main/java/org/opensearch/cluster/metadata/Metadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,6 @@ static Custom fromXContent(XContentParser parser, String name) throws IOExceptio
// handling any Exception is caller's responsibility
return parser.namedObject(Custom.class, name, null);
}

static Custom fromXContent(XContentParser parser) throws IOException {
shiv0408 marked this conversation as resolved.
Show resolved Hide resolved
String currentFieldName = parser.currentName();
return fromXContent(parser, currentFieldName);
}
}

public static final Setting<Integer> DEFAULT_REPLICA_COUNT_SETTING = Setting.intSetting(
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public class RemoteClusterStateService implements Closeable {
public static final ChecksumBlobStoreFormat<Metadata.Custom> CUSTOM_METADATA_FORMAT = new ChecksumBlobStoreFormat<>(
"custom",
METADATA_NAME_FORMAT,
Metadata.Custom::fromXContent
null // no need of reader here, as this object is only used to write/serialize the object
);

/**
Expand Down
Loading