Painless: ensure type "UnmodifiableMap" for params

[r1walz]

Description

See comment here: #10561 (comment)

Related Issues

Resolves #10561

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• API changes companion pull request created.
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[r1walz]

It's a user facing bug so removed skip-changelog label. I'll add change log once a round of gradle-check finishes.

[github-actions]

❕ Gradle check result for 5851f44: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (b15cb0c) to head (2973bb5).
Report is 332 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13885      +/-   ##
============================================
+ Coverage     71.42%   71.61%   +0.19%     
- Complexity    59978    61315    +1337     
============================================
  Files          4985     5065      +80     
  Lines        282275   288124    +5849     
  Branches      40946    41719     +773     
============================================
+ Hits         201603   206348    +4745     
- Misses        63999    64776     +777     
- Partials      16673    17000     +327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[r1walz]

Updated CHANGELOG.md due to conflict.

NOTE: change log of Pass parent filter to inner hit query was updated to #13903 from #13770. Hence, the conflict.

[github-actions]

✅ Gradle check result for 84817c7: SUCCESS

[gaobinlong]

Could we add a yml test case to verify we can always get the expected behavior?

[r1walz]

Hi. How can we specify number of nodes in the yml test? Also, how to send request to a specific node? I tried looking into the rest-api-spec folder and closest feature is node_selector but it only allows version and attribute as params. Can we even setup attribute through setup section? I'm lost here. Should we add integ test instead?

[reta]

Hi. How can we specify number of nodes in the yml test?

So the YAML client tests by default run with one node (if I am not mistaken) but the qa/* submodules create different configuration (nodes / versions etc). I think the only criteria you need is to have (under lang-painless/rest-api-specs tests):

  - skip:
      version: "- 2.14.99"
      reason: "The params are unmodifiable since 2.15.0"

Alternatively, you could use node selector instead, it would help you to always connect to right node:

      node_selector:
        version: "2.15.0 - "

[github-actions]

❌ Gradle check result for 0df68f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 2973bb5: SUCCESS

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13885-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 194005ebcaf79cf4f0f9fecd96d4b9e90ca9d1c0
# Push it to GitHub
git push --set-upstream origin backport/backport-13885-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13885-to-2.x.

[dblock]

@r1walz Can you please backport manually? Appreciate it.