Adding access to noSubMatches and noOverlappingMatches in Hyphenation…

[hasnain2808]

Description

This change adds support for / exposes two new settings (noSubMatches and noOverlappingMatches) that were added to Lucene's HyphenationCompoundWordTokenFilter class.

Related Issues

Resolves #8796
Based on of #10765

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• API changes companion pull request created.
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 5abc8ec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 5abc8ec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7b2142e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[jainankitk]

@hasnain2808 - It seems the spotless check is failing. Can you fix those?

Execution failed for task ':modules:analysis-common:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/opensearch/analysis/common/CompoundAnalysisTests.java
          @@ -35,7 +35,6 @@
           import·org.apache.lucene.analysis.Analyzer;
           import·org.apache.lucene.analysis.TokenStream;
           import·org.apache.lucene.analysis.tokenattributes.CharTermAttribute;
          -import·org.junit.Before;
           import·org.opensearch.Version;
           import·org.opensearch.cluster.metadata.IndexMetadata;
           import·org.opensearch.common.settings.Settings;
          @@ -51,6 +50,7 @@
           import·org.opensearch.test.IndexSettingsModule;
           import·org.opensearch.test.OpenSearchTestCase;
           import·org.hamcrest.MatcherAssert;
          +import·org.junit.Before;
           
           import·java.io.IOException;
           import·java.io.InputStream;
  Run './gradlew :modules:analysis-common:spotlessApply' to fix these violations.

[hasnain2808]

@hasnain2808 - It seems the spotless check is failing. Can you fix those?

Execution failed for task ':modules:analysis-common:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/opensearch/analysis/common/CompoundAnalysisTests.java
          @@ -35,7 +35,6 @@
           import·org.apache.lucene.analysis.Analyzer;
           import·org.apache.lucene.analysis.TokenStream;
           import·org.apache.lucene.analysis.tokenattributes.CharTermAttribute;
          -import·org.junit.Before;
           import·org.opensearch.Version;
           import·org.opensearch.cluster.metadata.IndexMetadata;
           import·org.opensearch.common.settings.Settings;
          @@ -51,6 +50,7 @@
           import·org.opensearch.test.IndexSettingsModule;
           import·org.opensearch.test.OpenSearchTestCase;
           import·org.hamcrest.MatcherAssert;
          +import·org.junit.Before;
           
           import·java.io.IOException;
           import·java.io.InputStream;
  Run './gradlew :modules:analysis-common:spotlessApply' to fix these violations.

Done
Weird this error was missed

[jainankitk]

@msfroh @mch2 - Can one of you help merge this change?

[github-actions]

❌ Gradle check result for 6a88bb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 8752b76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[hasnain2808]

@msfroh @mch2 - Can one of you help merge this change?

@msfroh @mch2 could you please have a look at this mini pr 🙂

[github-actions]

❌ Gradle check result for 8752b76: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 8752b76: SUCCESS

[hasnain2808]

I cannot merge even after approval 😢
Need your help again @msfroh 😄

[jainankitk]

I cannot merge even after approval 😢 Need your help again @msfroh 😄

Merged! :)